From: Cyrill Gorcunov <gorcunov@openvz.org>
To: mingo@elte.hu
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Lin Ming <ming.m.lin@intel.com>,
Cyrill Gorcunov <gorcunov@openvz.org>
Subject: [patch 3/4] x86,perf: P4 PMU -- Get rid of redundant check for array index
Date: Sat, 08 May 2010 15:25:53 +0400 [thread overview]
Message-ID: <20100508112717.130386882@openvz.org> (raw)
In-Reply-To: <20100508112550.187421916@openvz.org>
[-- Attachment #1: x86-perf-p4-redundant-check --]
[-- Type: text/plain, Size: 984 bytes --]
The caller already has done such a check.
And it was wrong anyway, it had to be '>=' rather then '>'
CC: Peter Zijlstra <peterz@infradead.org>
CC: Ingo Molnar <mingo@elte.hu>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
arch/x86/kernel/cpu/perf_event_p4.c | 5 -----
1 file changed, 5 deletions(-)
Index: linux-2.6.git/arch/x86/kernel/cpu/perf_event_p4.c
=====================================================================
--- linux-2.6.git.orig/arch/x86/kernel/cpu/perf_event_p4.c
+++ linux-2.6.git/arch/x86/kernel/cpu/perf_event_p4.c
@@ -406,11 +406,6 @@ static u64 p4_pmu_event_map(int hw_event
unsigned int esel;
u64 config;
- if (hw_event > ARRAY_SIZE(p4_general_events)) {
- printk_once(KERN_ERR "P4 PMU: Bad index: %i\n", hw_event);
- return 0;
- }
-
config = p4_general_events[hw_event];
bind = p4_config_get_bind(config);
esel = P4_OPCODE_ESEL(bind->opcode);
next prev parent reply other threads:[~2010-05-08 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-08 11:25 [patch 0/4] perf,p4 series for -tip Cyrill Gorcunov
2010-05-08 11:25 ` [patch 1/4] x86,perf: P4 PMU -- configurate predefined events Cyrill Gorcunov
2010-05-08 11:33 ` Cyrill Gorcunov
2010-05-10 12:43 ` Robert Richter
2010-05-08 11:25 ` [patch 2/4] x86,perf: P4 PMU -- protect sensible procedures from preemption Cyrill Gorcunov
2010-05-08 16:09 ` [tip:perf/core] x86, perf: " tip-bot for Cyrill Gorcunov
2010-05-08 11:25 ` Cyrill Gorcunov [this message]
2010-05-08 16:10 ` [tip:perf/core] x86, perf: P4 PMU -- Get rid of redundant check for array index tip-bot for Cyrill Gorcunov
2010-05-08 11:25 ` [patch 4/4] x86,perf: P4 PMU -- check for proper event index in RAW events Cyrill Gorcunov
2010-05-08 16:10 ` [tip:perf/core] x86, perf: " tip-bot for Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100508112717.130386882@openvz.org \
--to=gorcunov@openvz.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome