From: Samuel Ortiz <sameo@linux.intel.com>
To: Rabin Vincent <rabin@rab.in>
Cc: broonie@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: WM8350: remove incorrect kfree
Date: Sun, 9 May 2010 23:10:30 +0200 [thread overview]
Message-ID: <20100509211029.GB3269@sortiz.org> (raw)
In-Reply-To: <1271864165-8096-1-git-send-email-rabin@rab.in>
Hi Vincent,
On Wed, Apr 21, 2010 at 09:06:05PM +0530, Rabin Vincent wrote:
> The i2c_client received in probe() should not be kfree()'d.
Patch applied, many thanks.
Cheers,
Samuel.
> Signed-off-by: Rabin Vincent <rabin@rab.in>
> ---
> drivers/mfd/wm8350-i2c.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/wm8350-i2c.c b/drivers/mfd/wm8350-i2c.c
> index 65830f5..5fe5de1 100644
> --- a/drivers/mfd/wm8350-i2c.c
> +++ b/drivers/mfd/wm8350-i2c.c
> @@ -64,10 +64,8 @@ static int wm8350_i2c_probe(struct i2c_client *i2c,
> int ret = 0;
>
> wm8350 = kzalloc(sizeof(struct wm8350), GFP_KERNEL);
> - if (wm8350 == NULL) {
> - kfree(i2c);
> + if (wm8350 == NULL)
> return -ENOMEM;
> - }
>
> i2c_set_clientdata(i2c, wm8350);
> wm8350->dev = &i2c->dev;
> --
> 1.7.0.4
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-05-09 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 15:36 Rabin Vincent
2010-04-21 17:42 ` Mark Brown
2010-05-09 21:10 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100509211029.GB3269@sortiz.org \
--to=sameo@linux.intel.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®