From: Daniel Mack <daniel@caiaq.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, Anton Vorontsov <cbou@mail.ru>,
David Woodhouse <dwmw2@infradead.org>,
Andres Salomon <dilinger@collabora.co.uk>,
Alexey Starikovskiy <astarikovskiy@suse.de>,
Len Brown <len.brown@intel.com>, Matt Reimer <mreimer@vpop.net>,
Evgeniy Polyakov <zbr@ioremap.net>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 1/3] pda_power: add support for writeable properties
Date: Mon, 10 May 2010 15:29:48 +0200 [thread overview]
Message-ID: <20100510132948.GN30801@buzzloop.caiaq.de> (raw)
In-Reply-To: <20100510094854.GB31804@rakim.wolfsonmicro.main>
On Mon, May 10, 2010 at 10:48:54AM +0100, Mark Brown wrote:
> On Fri, May 07, 2010 at 07:52:11PM +0200, Daniel Mack wrote:
>
> > + /* TODO: support other types than int */
> > + ret = strict_strtol(buf, 10, &long_val);
> > + if (ret < 0)
> > + return ret;
>
> It'd be nicer if we could error out if this is used on properties with
> an inappropriate type but we don't seem to have type information
> anywhere convenient for implementing that, which is a bit unfortunate.
Yep, hence the 'TODO' :)
So currently the verdict is: if we can't convert the input to an
integer, we bail.
> Otherwise this looks reasonable in itself.
Ok, thanks.
Daniel
next prev parent reply other threads:[~2010-05-10 13:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 17:52 Daniel Mack
2010-05-07 17:52 ` [PATCH 2/3] power/ds2760_battery: make charge_now and charge_full_design writeable Daniel Mack
2010-05-10 9:52 ` Mark Brown
2010-05-10 13:28 ` Daniel Mack
2010-05-07 17:52 ` [PATCH 3/3] [RFC] power/ds2760_battery: use factor of 50 for rated_capacity Daniel Mack
2010-05-07 17:54 ` [PATCH 1/3] pda_power: add support for writeable properties Daniel Mack
2010-05-10 9:48 ` Mark Brown
2010-05-10 13:29 ` Daniel Mack [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-05-11 16:38 Daniel Mack
2010-05-11 17:47 ` Anton Vorontsov
2010-05-11 17:58 ` Daniel Mack
2010-05-11 18:23 ` Anton Vorontsov
2010-05-11 22:28 ` Daniel Mack
2010-05-11 18:32 ` Anton Vorontsov
2010-03-23 9:06 Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510132948.GN30801@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=astarikovskiy@suse.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cbou@mail.ru \
--cc=dilinger@collabora.co.uk \
--cc=dwmw2@infradead.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mreimer@vpop.net \
--cc=tj@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome