mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: John Stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mundt <lethal@linux-sh.org>,
	Jim Cromie <jim.cromie@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC][PATCH 3/3] Try to convert non-trivial clocksources to clocksource_register_hz
Date: Mon, 10 May 2010 17:53:38 +0200	[thread overview]
Message-ID: <20100510175338.05ef5db8@mschwide.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1272677785-23881-3-git-send-email-johnstul@us.ibm.com>

On Fri, 30 Apr 2010 18:36:25 -0700
John Stultz <johnstul@us.ibm.com> wrote:

> NOT FOR INCLUSION!
> NOT FOR INCLUSION!
> 
> I've already gone through and converted the rest of the clocksources 
> to use clocksource_register_hz, and I'll be hopefully pushing those 
> to arch maintainers for 2.6.36-2.6.37.
> 
> However, in going through all the clocksources, I hit a few
> non-trivial conversions and wanted to bring them up on the list
> early so they can be handled soon.
> 
> The following patch tries to convert the non-trival clocksources
> to use clocksource_register_hz/khz. It is likely broken. I will
> need arch maintainer help to figure out the best way to resovle 
> these clocksources.
> 
> This patch requires the previous "Add clocksource_register_hz/khz 
> interface" patch to build. 
> 
> So any help maintainers can provide in finding solutions to
> break the mult/shift assumptions in the arch code would be
> greatly appreciated!
> 
> thanks
> -john
> 
> NOT FOR INCLUSION!
> NOT FOR INCLUSION!

The s390 conversion to clocksource_register_khz looks good - at least
the kilo hertz value is correct. Bit 2^12 of the TOD value are
microseconds, which makes one millisecond (1000<<12). 

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.


  reply	other threads:[~2010-05-10 15:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-01  1:36 [PATCH 1/3] Add clocksource_register_hz/khz interface John Stultz
2010-05-01  1:36 ` [PATCH 2/3] Convert common x86 clocksources to use clocksource_register_hz/khz John Stultz
2010-05-01  1:36   ` [RFC][PATCH 3/3] Try to convert non-trivial clocksources to clocksource_register_hz John Stultz
2010-05-10 15:53     ` Martin Schwidefsky [this message]
2010-05-10 19:19       ` john stultz
2010-05-11  6:20         ` Martin Schwidefsky
2010-05-10 21:33     ` Jim Cromie
2010-05-11  0:04       ` john stultz
2010-05-11  1:51         ` Jim Cromie
2010-05-11  0:37       ` john stultz
2010-05-12 16:43         ` Julien Ridoux
2010-05-01  8:45 ` [PATCH 1/3] Add clocksource_register_hz/khz interface Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100510175338.05ef5db8@mschwide.boeblingen.de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=jim.cromie@gmail.com \
    --cc=johnstul@us.ibm.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®