From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Robert Richter <robert.richter@amd.com>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
Roland McGrath <roland@redhat.com>,
DLE <dle-develop@lists.sourceforge.net>
Subject: Re: [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old
Date: Mon, 10 May 2010 15:57:29 -0300 [thread overview]
Message-ID: <20100510185729.GB19192@ghostprotocols.net> (raw)
In-Reply-To: <20100510183654.GH6450@erda.amd.com>
Em Mon, May 10, 2010 at 08:36:54PM +0200, Robert Richter escreveu:
> On 10.05.10 13:28:54, Arnaldo Carvalho de Melo wrote:
> > Em Mon, May 10, 2010 at 01:12:07PM -0400, Masami Hiramatsu escreveu:
> > > Check elfutils version, and if it is old don't compile CFI
> > > analysis code. This allows to compile perf with old elfutils.
> > _ELFUTILS_PREREQ was introduced in:
> > commit fbc7245df72ce0142f0a21fa0f4f88c97278bf60
> > Author: Roland McGrath <roland@redhat.com>
> > Date: Tue Dec 16 17:03:03 2008 -0800
> > Which was released in elfutils 0.138, guess this is coverage enough?
> > Richard, which version is in your machine?
> Right, this does not work, I am using 0.131. As expected,
> "_ELFUTILS_PREREQ" is not defined:
> util/probe-finder.h:47:5: error: "_ELFUTILS_PREREQ" is not defined
> util/probe-finder.h:47:21: error: missing binary operator before token "("
> make: *** [builtin-probe.o] Error 1
> Why not create a compile test as for NO_DWARF in tools/perf/Makefile?
Right, that would be better.
- Arnaldo
next prev parent reply other threads:[~2010-05-10 18:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 17:12 Masami Hiramatsu
2010-05-10 17:28 ` Arnaldo Carvalho de Melo
2010-05-10 18:36 ` Robert Richter
2010-05-10 18:57 ` Arnaldo Carvalho de Melo [this message]
2010-05-10 18:57 ` Masami Hiramatsu
2010-05-10 19:15 ` Arnaldo Carvalho de Melo
2010-05-10 19:19 ` Masami Hiramatsu
2010-05-11 4:59 ` [PATCH -tip] perf probe: Check older elfutils and set NO_DWARF Masami Hiramatsu
2010-05-11 10:41 ` Robert Richter
2010-05-12 8:40 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-05-11 8:12 ` [PATCH -tip] perf probe: Don't compile CFI related code if elfutils is old Mark Wielaard
2010-05-18 1:57 ` [tip:perf/core] " tip-bot for Masami Hiramatsu
2010-05-18 9:35 ` Robert Richter
2010-05-18 9:39 ` Stephane Eranian
2010-05-18 10:18 ` Robert Richter
2010-05-18 14:03 ` acme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510185729.GB19192@ghostprotocols.net \
--to=acme@infradead.org \
--cc=dle-develop@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
--cc=roland@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome