From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933278Ab0EKHEV (ORCPT ); Tue, 11 May 2010 03:04:21 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:53455 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753331Ab0EKHEU (ORCPT ); Tue, 11 May 2010 03:04:20 -0400 Date: Tue, 11 May 2010 09:03:50 +0200 From: Ingo Molnar To: Lin Ming Cc: Cyrill Gorcunov , LKML , Peter Zijlstra , Steven Rostedt , Frederic Weisbecker Subject: Re: [rfc] x86,perf: P4 PMU -- use hash for p4_get_escr_idx Message-ID: <20100511070350.GA5195@elte.hu> References: <20100510152708.GS5104@lenovo> <1273558879.30322.8.camel@minggr.sh.intel.com> <20100511063047.GA24365@elte.hu> <20100511064144.GA29063@elte.hu> <1273560424.30322.13.camel@minggr.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1273560424.30322.13.camel@minggr.sh.intel.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lin Ming wrote: > On Tue, 2010-05-11 at 14:41 +0800, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > > > > > > * Lin Ming wrote: > > > > > > > On Mon, 2010-05-10 at 23:27 +0800, Cyrill Gorcunov wrote: > > > > > Hi Ming, > > > > > > > > > > could you give this patch a shot if possible? Compile > > > > > tested only. I would appreciate review and complains > > > > > as well :) I know you're busy with other perf task > > > > > so there is no hurry. Just to share the patch as early > > > > > as possible. > > > > > > > > Hi, > > > > > > > > I'm going to test this patch, but current tip/master(c6661c5) seems has > > > > problem. > > > > > > Does reverting 4fd38e4595e2f6c9d27732c042a0e16b2753049c help? > > > > If not then it would be nice if you could try to do a bisection. > > Yes, it's the commit 4fd38e45 causes the regression. Thanks, i've reverted it. Ingo