From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756685Ab0EKGFG (ORCPT ); Tue, 11 May 2010 02:05:06 -0400 Received: from cantor.suse.de ([195.135.220.2]:48849 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756300Ab0EKGFD (ORCPT ); Tue, 11 May 2010 02:05:03 -0400 From: Oliver Neukum Organization: SUSE To: Andrew Morton Subject: Re: [patch]hp_accel: Fix race in device removal Date: Tue, 11 May 2010 08:04:45 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.34-rc6-0.1-default; KDE/4.3.5; x86_64; ; ) Cc: Eric Piel , Pavel Machek , Pavel Herrmann , lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, stable@kernel.org References: <201005071804.20462.oneukum@suse.de> <201005110755.07717.oneukum@suse.de> <20100510225725.6bfdc4a5.akpm@linux-foundation.org> In-Reply-To: <20100510225725.6bfdc4a5.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201005110804.45251.oneukum@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, 11. Mai 2010 04:57:25 schrieb Andrew Morton: > On Tue, 11 May 2010 07:55:07 +0200 Oliver Neukum wrote: > > > Am Dienstag, 11. Mai 2010 00:46:32 schrieb Andrew Morton: > > > But alas, I (and presumably others) cannot confirm that, because you > > > didn't describe the bug :( This also means that if someone hits a > > > problem with this driver, they won't easily be able to work out whether > > > this patch will fix it. > > > > > > > > > Under what circumstances does it trigger? > > > > > > What are the observed effects when it triggers? > > > > > > Please always include this sort of information when sending bugfixes, thanks. > > > > Sorry, > > > > the patch closes a window during which a work queue might remain > > active after the device is removed and would then lead to ACPI calls > > with undefined behavior. > > Had anyone observed this in the field? Was a machine crashing, perhaps? No, this was found during a code review. Regards Oliver