Re: [PATCH 1/3] EEPROM: Header file cleanup

[Greg KH <greg@kroah.com>]

On Wed, May 12, 2010 at 11:38:14AM +0200, Jean Delvare wrote:
> On Wed, 12 May 2010 11:30:15 +0200, Wolfram Sang wrote:
> > On Tue, May 11, 2010 at 01:08:15PM -0500, Arce, Abraham wrote:
> > > Change eeprom.c header file to format as in conventions
> > > 
> > > Signed-off-by: Abraham Arce <x0066660@ti.com>
> > > ---
> > >  drivers/misc/eeprom/eeprom.c |   40 ++++++++++++++++++++--------------------
> > >  1 files changed, 20 insertions(+), 20 deletions(-)
> > > 
> > > diff --git a/drivers/misc/eeprom/eeprom.c b/drivers/misc/eeprom/eeprom.c
> > > index f939ebc..fffa2e8 100644
> > > --- a/drivers/misc/eeprom/eeprom.c
> > > +++ b/drivers/misc/eeprom/eeprom.c
> > > @@ -1,24 +1,24 @@
> > >  /*
> > > -    Copyright (C) 1998, 1999  Frodo Looijaard <frodol@dds.nl> and
> > > -			       Philip Edelbrock <phil@netroedge.com>
> > > -    Copyright (C) 2003 Greg Kroah-Hartman <greg@kroah.com>
> > > -    Copyright (C) 2003 IBM Corp.
> > > -    Copyright (C) 2004 Jean Delvare <khali@linux-fr.org>
> > > -
> > > -    This program is free software; you can redistribute it and/or modify
> > > -    it under the terms of the GNU General Public License as published by
> > > -    the Free Software Foundation; either version 2 of the License, or
> > > -    (at your option) any later version.
> > > -
> > > -    This program is distributed in the hope that it will be useful,
> > > -    but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > -    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > -    GNU General Public License for more details.
> > > -
> > > -    You should have received a copy of the GNU General Public License
> > > -    along with this program; if not, write to the Free Software
> > > -    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> > > -*/
> > > + * Copyright (C) 1998, 1999  Frodo Looijaard <frodol@dds.nl> and
> > > + *                           Philip Edelbrock <phil@netroedge.com>
> > > + * Copyright (C) 2003 Greg Kroah-Hartman <greg@kroah.com>
> > > + * Copyright (C) 2003 IBM Corp.
> > > + * Copyright (C) 2004 Jean Delvare <khali@linux-fr.org>
> > > + *
> > > + * This program is free software; you can redistribute it and/or modify
> > > + * it under the terms of the GNU General Public License as published by
> > > + * the Free Software Foundation; either version 2 of the License, or
> > > + * (at your option) any later version.
> > > + *
> > > + * This program is distributed in the hope that it will be useful,
> > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > + * GNU General Public License for more details.
> > > + *
> > > + * You should have received a copy of the GNU General Public License
> > > + * along with this program; if not, write to the Free Software
> > > + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> > > + */
> > 
> > If you are touching this anyhow, could you also update the address of the FSF?
> > (or maybe remove the address block if the original authors are fine with it).
> 
> This would definitely be fine with me (even though I'm not the original
> author.)

Removing it would be fine, and better.

thanks,

greg k-h