From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: mjg@redhat.com, mzxreary@0pointer.de, rpurdie@linux.intel.com,
jlee@novell.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH 4/4] msi-laptop: Add i8042 filter to sync sw state with BIOS when function key pressed
Date: Thu, 13 May 2010 00:52:18 -0700 [thread overview]
Message-ID: <20100513075217.GC30110@core.coreip.homeip.net> (raw)
In-Reply-To: <20100512185647.GC28990@suse.de>
On Wed, May 12, 2010 at 11:56:47AM -0700, Greg KH wrote:
> static int __init msi_init(void)
> @@ -819,6 +875,7 @@ static void __exit msi_cleanup(void)
> platform_driver_unregister(&msipf_driver);
> backlight_device_unregister(msibl_device);
>
> + i8042_remove_filter(msi_laptop_i8042_filter);
You also need cancel_delayed_work_sync() here. Sorry for not noticing
this before.
> rfkill_cleanup();
>
> /* Enable automatic brightness control again */
--
Dmitry
next prev parent reply other threads:[~2010-05-13 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100512141149.GB20564@kroah.com>
2010-05-12 16:58 ` [PATCH 1/4] msi-laptop: Add N014 N051 dmi information to scm models table Greg Kroah-Hartman
2010-05-12 16:58 ` [PATCH 2/4] msi-laptop: Add MSI CR620 notebook " Greg Kroah-Hartman
2010-05-12 16:58 ` [PATCH 3/4] msi-laptop: Set rfkill init state when msi-laptop intiial Greg Kroah-Hartman
2010-05-12 16:58 ` [PATCH 4/4] msi-laptop: Add i8042 filter to sync sw state with BIOS when function key pressed Greg Kroah-Hartman
2010-05-12 17:33 ` Dmitry Torokhov
2010-05-12 18:55 ` Greg KH
2010-05-12 18:56 ` Greg KH
2010-05-13 7:52 ` Dmitry Torokhov [this message]
2010-05-13 11:53 Joey Lee
2010-05-13 22:54 ` Greg KH
2010-05-14 0:37 Joey Lee
2010-05-14 22:49 Joey Lee
2010-05-20 13:32 ` Matthew Garrett
2010-05-20 13:39 Joey Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513075217.GC30110@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=jlee@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=mzxreary@0pointer.de \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®