From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Huaxu Wan <huaxu.wan@linux.intel.com>
Cc: huaxu.wan@intel.com, Valdis.Kletnieks@vt.edu,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 1/2 V3] hwmon: (coretemp) Detect the thermal sensors by CPUID
Date: Fri, 14 May 2010 00:20:01 -0300 [thread overview]
Message-ID: <20100514032000.GB17786@khazad-dum.debian.net> (raw)
In-Reply-To: <20100511080112.GB19762@owl>
On Tue, 11 May 2010, Huaxu Wan wrote:
> + printk(KERN_INFO DRVNAME ": CPU (model=0x%x)"
> + " has no thermal sensor!\n", c->x86_model);
IMHO, it is better to drop that "!" since it is now a simple status message,
otherwise it still looks like there is something wrong with the CPU not
having a thermal sensor.
Minor thing, really, so feel free to ignore this comment.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2010-05-14 3:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 9:54 [PATCH 1/2] " Huaxu Wan
2010-05-07 12:43 ` Jean Delvare
2010-05-07 13:21 ` [lm-sensors] " Carsten Emde
2010-05-10 2:35 ` Huaxu Wan
2010-05-10 3:35 ` [PATCH 1/2 V2] " Huaxu Wan
2010-05-10 12:45 ` Valdis.Kletnieks
2010-05-11 3:41 ` Huaxu Wan
2010-05-11 8:01 ` [PATCH 1/2 V3] " Huaxu Wan
2010-05-11 21:45 ` Valdis.Kletnieks
2010-05-14 3:20 ` Henrique de Moraes Holschuh [this message]
2010-05-14 6:58 ` [PATCH 1/2 V3 minor change] " Huaxu Wan
2010-05-17 9:41 ` [PATCH 0/2] hwmon: Update coretemp to current Intel processors Carsten Emde
2010-05-17 9:41 ` [PATCH 1/2] Detect the thermal sensors by CPUID Carsten Emde
2010-05-17 9:41 ` [PATCH 2/2] Get TjMax value from MSR Carsten Emde
[not found] ` <AANLkTinQlH7LhCAz00WaHqbbslcSqipzVx4tDoQKSqIL@mail.gmail.com>
2010-05-18 7:01 ` [lm-sensors] [PATCH 0/2] hwmon: Update coretemp to current Intel processors Carsten Emde
2010-05-18 12:03 ` Dmitry Gromov
2010-05-19 1:27 ` Huaxu Wan
[not found] ` <625BA99ED14B2D499DC4E29D8138F150181F574C31@shsmsx502.ccr.corp.intel.com>
[not found] ` <AANLkTimQnaUvXs75rpTOcW7CODXWgUfzekY9FCDa5S8P@mail.gmail.com>
2010-05-18 7:13 ` Carsten Emde
2010-05-19 0:50 ` Huaxu Wan
2010-05-19 3:12 ` Dmitry Gromov
2010-05-07 9:59 [PATCH 2/2] hwmon: (coretemp) Get TjMax value from MSR Huaxu Wan
2010-05-07 13:29 ` [lm-sensors] " Carsten Emde
2010-05-10 3:09 ` Huaxu Wan
2010-05-10 3:50 ` [PATCH 2/2 V2] " Huaxu Wan
2010-05-29 5:39 ` [PATCH 2/2] " Maxim Levitsky
2010-05-30 14:43 ` Maxim Levitsky
2010-05-31 1:39 ` Huaxu Wan
2010-06-02 16:34 ` Maxim Levitsky
2010-06-02 20:10 ` Maxim Levitsky
2010-06-12 13:03 ` Maxim Levitsky
2010-06-13 2:27 ` Wan, Huaxu
2010-07-26 8:16 ` Maxim Levitsky
2010-08-30 1:42 ` Huaxu Wan
2010-08-31 21:01 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514032000.GB17786@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=Valdis.Kletnieks@vt.edu \
--cc=huaxu.wan@intel.com \
--cc=huaxu.wan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®