mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jiaying Zhang <jiayingz@google.com>
Cc: hch@infradead.org, jens.axboe@oracle.com,
	linux-kernel@vger.kernel.org, mrubin@google.com
Subject: Re: [PATCH, RFC] addjust discard request to be aligned with hwsect size to support SSDs with larger sector size
Date: Sun, 16 May 2010 09:38:20 -0400	[thread overview]
Message-ID: <20100516133820.GA25820@infradead.org> (raw)
In-Reply-To: <20100513051953.532821BC316@ruihe.smo.corp.google.com>

On Wed, May 12, 2010 at 10:19:53PM -0700, Jiaying Zhang wrote:
> The currect blkdev_issue_discard() function assumes 512 sector size.
> We have seen some problem when using discard on a SSD that has larger
> sector size. The following patch adjusts the starting address and size of
> a discard request to be aligned with hwsect size.

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>

> -	if (!blk_queue_discard(q))
> +	if (!blk_queue_discard(q) || q->limits.max_discard_sectors == 0)
>  		return -EOPNOTSUPP;

But this change is unrelated.  It's fine with me, but needs a patch of
it's own with a proper description.


  reply	other threads:[~2010-05-16 13:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13  5:19 Jiaying Zhang
2010-05-16 13:38 ` Christoph Hellwig [this message]
2010-05-17 19:27   ` Jiaying Zhang
2010-05-17 18:57 ` Martin K. Petersen
2010-05-17 19:44   ` Jiaying Zhang
2010-05-17 20:00     ` Martin K. Petersen
2010-05-18  0:57       ` Jiaying Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100516133820.GA25820@infradead.org \
    --to=hch@infradead.org \
    --cc=jens.axboe@oracle.com \
    --cc=jiayingz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mrubin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®