From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Florian Fainelli <florian@openwrt.org>
Cc: mingo@elte.hu, "linux-kernel" <linux-kernel@vger.kernel.org>,
andi@firstfloor.org
Subject: Re: [PATCH] x86: CPU detection for RDC System-on-Chip
Date: Sun, 16 May 2010 14:19:17 +0100 [thread overview]
Message-ID: <20100516141917.0d2e69e2@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <201005161455.34100.florian@openwrt.org>
> + case 0x00321004: /* tested */
> + strcpy(c->x86_model_id, "S3282/CodeTek");
> + break;
> + case 0x00321007:
> + strcpy(c->x86_model_id, "R8610");
> + break;
> + default:
> + pr_info("RDC CPU: Unrecognised Customer ID (0x%x) please "
> + "report to: linux-kernel@vger.kernel.org\n",
> + customer_id);
Surely this should be a break as you want to set the vendor. You've
established its an RDC at this point have you not - so you want to set
x86_vendor.
Alan
next prev parent reply other threads:[~2010-05-16 13:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-16 12:55 Florian Fainelli
2010-05-16 13:19 ` Alan Cox [this message]
2010-05-16 13:21 ` Florian Fainelli
2010-05-16 22:07 ` H. Peter Anvin
2010-05-17 6:12 ` Florian Fainelli
2010-05-17 11:40 ` Florian Fainelli
2010-05-19 7:27 ` [PATCH v3] " Florian Fainelli
2010-05-20 14:58 ` Florian Fainelli
2010-06-03 8:32 ` Florian Fainelli
2010-05-17 11:23 ` [PATCH] " Andi Kleen
2010-05-17 11:39 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100516141917.0d2e69e2@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®