From: Greg KH <greg@kroah.com>
To: Nitin Gupta <ngupta@vflare.org>
Cc: Minchan Kim <minchan.kim@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>, Cyp <cyp561@gmail.com>,
driverdev <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ramzswap: Remove backing swap support
Date: Sun, 16 May 2010 16:58:35 -0700 [thread overview]
Message-ID: <20100516235835.GA22456@kroah.com> (raw)
In-Reply-To: <4BF02267.3000705@vflare.org>
On Sun, May 16, 2010 at 10:20:47PM +0530, Nitin Gupta wrote:
> On 05/16/2010 09:51 PM, Greg KH wrote:
> > On Sun, May 16, 2010 at 09:13:46PM +0530, Nitin Gupta wrote:
> >> Hi Minchan,
> >>
> >> On 05/16/2010 09:50 AM, Minchan Kim wrote:
> >>
> >>> One thing was about naming.
> >>> Now block device operations has field naming swap_xxx_notify
> >>> (I am not sure exact name). My concern was it's very specific about swap.
> >>> So I thought we would be better to more abstract name.
> >>>
> >>> I thought trim like naming as Linus said.
> >>
> >> This call is very swap specific and is quite different from generic trim
> >> stuff. So, I think it will be better not be generalize the name and avoid
> >> confusing it with trim/discard etc.
> >>
> >>>
> >>> Anyway, I will review again at next week if it isn't merged
> >>> linux-next(or linux-mm ?? which is right?). That's because I have a
> >>> interest in your good ramzswap. :)
> >>>
> >>
> >> Thanks, comments/reviews are always welcome :)
> >>
> >> Greg: In the meantime, considering 3 Acks, is it possible to pull it in
> >> linux-next?
> >
> > It's already there, right?
> >
>
> Yuk! its there.
>
> I actually wanted to refer to the 'swap notify patch'. Please see patch titled:
> 'ramzswap: Eliminate stale data from compressed memory (v2)'
> (http://thread.gmane.org/gmane.linux.kernel/982232)
>
> This patch got 3 Acks: Pekka, Linus and Nigel.
Yes, I can't take that one, as it is outside of the drivers/staging/
tree. Unless no one else objects? Which, I guess no one does, hm,
sorry about that. Care to resend them to me so I can queue them up?
thanks,
greg k-h
prev parent reply other threads:[~2010-05-16 23:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 8:54 Nitin Gupta
2010-05-13 15:15 ` Pekka Enberg
2010-05-16 4:20 ` Minchan Kim
2010-05-16 15:43 ` Nitin Gupta
2010-05-16 16:21 ` Greg KH
2010-05-16 16:50 ` Nitin Gupta
2010-05-16 23:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100516235835.GA22456@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=cyp561@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan.kim@gmail.com \
--cc=ngupta@vflare.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome