From: Christoph Egger <siccegge@cs.fau.de>
To: Greg Kroah-Hartman <gregkh@suse.de>,
Kay Sievers <kay.sievers@vrfy.org>, Jan Blunck <jblunck@suse.de>,
Emese Revfy <re.emese@gmail.com>,
"Eric W. Biederman" <ebiederm@aristanetworks.com>,
linux-kernel@vger.kernel.org
Cc: vamos@i4.informatik.uni-erlangen.de
Subject: [PATCH] Typo in drivers/base/core.c
Date: Mon, 17 May 2010 16:57:58 +0200 [thread overview]
Message-ID: <20100517145757.GA3686@faui49.informatik.uni-erlangen.de> (raw)
Hi all!
As part of the VAMOS[0] research project at the University of
Erlangen we are looking at multiple integrity errors in linux'
configuration system.
There's a typo in linux' source (CONFIG_MODULE -- missing the
final S) making the whole codeblock unselectable. The included patch
should address this issue.
Please keep me informed of this patch getting confirmed /
merged so we can keep track of it.
Regards
Christoph Egger
[0] http://vamos1.informatik.uni-erlangen.de/
----
>From d5fe80140757fedfe19c293cd7af4c1030b92353 Mon Sep 17 00:00:00 2001
From: Christoph Egger <siccegge@cs.fau.de>
Date: Mon, 17 May 2010 16:48:59 +0200
Subject: [PATCH] CONFIG_MODULES misstyped as _MODULE
In this code section the final S of CONFIG_MODULES was missed making
the whole check useless
Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
---
drivers/base/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index b56a0ba..f801c36 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1372,7 +1372,7 @@ struct device *__root_device_register(const char *name, struct module *owner)
return ERR_PTR(err);
}
-#ifdef CONFIG_MODULE /* gotta find a "cleaner" way to do this */
+#ifdef CONFIG_MODULES /* gotta find a "cleaner" way to do this */
if (owner) {
struct module_kobject *mk = &owner->mkobj;
--
1.6.3.3
next reply other threads:[~2010-05-17 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 14:57 Christoph Egger [this message]
2010-05-17 15:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517145757.GA3686@faui49.informatik.uni-erlangen.de \
--to=siccegge@cs.fau.de \
--cc=ebiederm@aristanetworks.com \
--cc=gregkh@suse.de \
--cc=jblunck@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=re.emese@gmail.com \
--cc=vamos@i4.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®