From: Greg KH <greg@kroah.com>
To: Neil Munro <neilmunro@gmail.com>
Cc: gregkh@suse.de, wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: Staging: Rt2860: Fixed all but one error in mlme.h
Date: Tue, 18 May 2010 14:49:15 -0700 [thread overview]
Message-ID: <20100518214915.GA21880@kroah.com> (raw)
In-Reply-To: <1274096666-3282-1-git-send-email-neilmunro@gmail.com>
On Mon, May 17, 2010 at 12:44:26PM +0100, Neil Munro wrote:
> From: Neil Munro <neilmunro@gmail.com>
>
> Fixed all but error in mlme.h, I don't know how to fix the remaining
> error. It complains about parenthesis and do-while loops, maybe someone
> else can fix that?
>
> Signed-off-by: Neil Munro <neilmunro@gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> drivers/staging/rt2860/mlme.h | 13 ++++++-------
> 1 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rt2860/mlme.h b/drivers/staging/rt2860/mlme.h
> index 1143413..63cada3 100644
> --- a/drivers/staging/rt2860/mlme.h
> +++ b/drivers/staging/rt2860/mlme.h
> @@ -60,7 +60,7 @@
> #define JAP_W56 4
> #define MAX_RD_REGION 5
>
> -#define BEACON_LOST_TIME 4 * OS_HZ /* 2048 msec = 2 sec */
> +#define BEACON_LOST_TIME { 4 * OS_HZ } /* 2048 msec = 2 sec */
This is not correct, you need to use ( ) here.
And you can ignore the checkconfig error about the do-while loop here,
that's a bug in the script.
Care to redo this patch?
thanks,
greg k-h
prev parent reply other threads:[~2010-05-18 22:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 11:44 [PATCH 229/229] " Neil Munro
2010-05-17 21:06 ` Joe Perches
2010-05-18 21:49 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518214915.GA21880@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=neilmunro@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome