Re: [PATCH] mfd: new AB8500 driver

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Rabin,

On Mon, May 17, 2010 at 09:30:06PM +0530, Rabin VINCENT wrote:
> Hi Samuel,
> 
> On Mon, May 17, 2010 at 00:53:55 +0200, Samuel Ortiz wrote:
> > On Tue, May 11, 2010 at 10:15:31AM +0530, Rabin Vincent wrote:
> > > Add a new driver to support the AB8500 Power Management chip, replacing
> > > the current AB4500.  The new driver replaces the old one, instead of an
> > > incremental modification, because this is a substantial overhaul
> > > including:
> > > 
> > >  - Split of the driver into -core and -spi portions, to allow another
> > >    interface layer to be added
> > > 
> > >  - Addition of interrupt support
> > > 
> > >  - Switch to MFD core API for handling subdevices
> > > 
> > >  - Simplification of the APIs to remove a redundant block parameter
> > > 
> > >  - Rename of the APIs and macros from ab4500_* to ab8500_*
> > > 
> > >  - Rename of the files from ab4500* to ab8500*
> > > 
> > > The driver still identifes itself as "ab4500" 
> > The patch looks good, but why not changing that to "ab8500" and integrating
> > the relevant board file changes to this patch ?
> 
> I originally didn't do this because I thought that this would create
> merge conflicts with some code movement in the arm tree, but looks like
> I was wrong -- there won't be conflicts for this change.
> 
> So, the updated patch below also includes the board file change to
> change the driver name from ab4500 to ab8500.  (It also includes a small
> fix to the interrupt handling, found after the previous version was
> sent.)
Thanks, patch applied to my for-next branch.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/