From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756920Ab0ERQae (ORCPT ); Tue, 18 May 2010 12:30:34 -0400 Received: from sh.osrg.net ([192.16.179.4]:57789 "EHLO sh.osrg.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755372Ab0ERQa3 (ORCPT ); Tue, 18 May 2010 12:30:29 -0400 Date: Wed, 19 May 2010 01:24:23 +0900 (JST) Message-Id: <20100519.012423.218986668.ryusuke@osrg.net> To: stable Cc: linux-nilfs@vger.kernel.org, konishi.ryusuke@lab.ntt.co.jp, linux-kernel@vger.kernel.org Subject: [stable] nilfs2: fix sync silent failure From: Ryusuke Konishi X-Mailer: Mew version 5.2 on Emacs 22.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (sh.osrg.net [192.16.179.4]); Wed, 19 May 2010 01:24:24 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please consider commit 973bec34bfc1bc2465646181653d67f767d418c8 for inclusion in 2.6.33.y and 2.6.32.y. Here is the commit message. It fixes a grave regression since 2.6.32, which makes "sync" operation nonfunctional, and leading to unexpected user's data loss. I have tested the patch, and confirmed that it restores the function of "sync" for both 2.6.33.y and 2.6.32.y. Unfortunetaly, the patch didn't apply to 2.6.32.y as is (3-way merge was required). To make sure, I will later post an adjusted patch against 2.6.32.y. Thanks, Ryusuke Konishi commit 973bec34bfc1bc2465646181653d67f767d418c8 Author: Ryusuke Konishi Date: Mon May 3 21:00:48 2010 +0900 nilfs2: fix sync silent failure As of 32a88aa1, __sync_filesystem() will return 0 if s_bdi is not set. And nilfs does not set s_bdi anywhere. I noticed this problem by the warning introduced by the recent commit 5129a469 ("Catch filesystem lacking s_bdi"). WARNING: at fs/super.c:959 vfs_kern_mount+0xc5/0x14e() Hardware name: PowerEdge 2850 Modules linked in: nilfs2 loop tpm_tis tpm tpm_bios video shpchp pci_hotplug output dcdbas Pid: 3773, comm: mount.nilfs2 Not tainted 2.6.34-rc6-debug #38 Call Trace: [] warn_slowpath_common+0x60/0x90 [] warn_slowpath_null+0xd/0x10 [] vfs_kern_mount+0xc5/0x14e [] do_kern_mount+0x32/0xbd [] do_mount+0x671/0x6d0 [] ? __get_free_pages+0x1f/0x21 [] ? copy_mount_options+0x2b/0xe2 [] ? strndup_user+0x48/0x67 [] sys_mount+0x61/0x8f [] sysenter_do_call+0x12/0x32 This ensures to set s_bdi for nilfs and fixes the sync silent failure. Signed-off-by: Ryusuke Konishi Acked-by: Jens Axboe Signed-off-by: Linus Torvalds