mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Arnaldo Carvalho de Melo <acme@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	"Stephane Eranian" <eranian@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Mike Galbraith" <efault@gmx.de>,
	"Paul Mackerras" <paulus@samba.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Tom Zanussi" <tzanussi@gmail.com>,
	"Arnaldo Carvalho de Melo" <acme@redhat.com>
Subject: Re: [PATCH 1/5] perf stat: add perf stat -B to pretty print large numbers
Date: Wed, 19 May 2010 08:28:32 +0200	[thread overview]
Message-ID: <20100519062832.GB21294@elte.hu> (raw)
In-Reply-To: <1274234900-12162-2-git-send-email-acme@infradead.org>


* Arnaldo Carvalho de Melo <acme@infradead.org> wrote:

> From: Stephane Eranian <eranian@google.com>
> 
> It is hard to read very large numbers so provide an 
> option to perf stat to separate thousands using a 
> separator. The patch leverages the locale support of 
> stdio. You need to set your LC_NUMERIC appropriately, 
> for instance LC_NUMERIC=en_US.UTF8. You need to pass -B 
> to activate this feature. This way existing scripts 
> parsing the output do not need to be changed. Here is an 
> example.

I've pulled it, but IMO we should go one step further: 
this feature should be made unconditional. The current 
numbers displayed by perf stat are often human-unreadable.

scripts should not parse pretty-printed output.

We used to have something like that, in the form of:

  perf record --no-samples --stat -e cycles -e instructions -a sleep 1
  perf report -n -t :

But the Newt changes broke this stat-only recording mode. 
Furthermore, there should be a --raw kind out output mode 
for perf stat as well.

Thanks,

	Ingo

  reply	other threads:[~2010-05-19  6:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19  2:08 [GIT PULL v2 0/5] perf tools fixes and improvements Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH 1/5] perf stat: add perf stat -B to pretty print large numbers Arnaldo Carvalho de Melo
2010-05-19  6:28   ` Ingo Molnar [this message]
2010-05-31 19:11   ` Valdis.Kletnieks
2010-05-31 19:30     ` Stephane Eranian
2010-05-31 20:49       ` Valdis.Kletnieks
2010-05-31 23:11         ` Arnaldo Carvalho de Melo
2010-05-31 23:37           ` Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH 2/5] perf tools: Remove some unused functions Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH v2 3/5] perf probe: Fix some error exit paths Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH v2 4/5] perf probe: Don't call die() Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH 5/5] perf tools: remove xstrndup, xmalloc, xzalloc Arnaldo Carvalho de Melo
  -- strict thread matches above, loose matches on Subject: below --
2010-05-19  0:27 [GIT PULL 0/5] perf tools fixes and improvements Arnaldo Carvalho de Melo
2010-05-19  0:27 ` [PATCH 1/5] perf stat: add perf stat -B to pretty print large numbers Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100519062832.GB21294@elte.hu \
    --to=mingo@elte.hu \
    --cc=acme@infradead.org \
    --cc=acme@redhat.com \
    --cc=davem@davemloft.net \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®