From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Rupjyoti Sarmah <rsarmah@amcc.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
jgarzik@pobox.com, sr@denx.de, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH]460EX on-chip SATA driver <Kernel 2.6.33> < resubmission >
Date: Wed, 19 May 2010 10:53:05 +0100 [thread overview]
Message-ID: <20100519105305.54804b57@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <AANLkTiljlMJKimdT-ptwXrMMBhSxFuPdVdyUuKJ8BZve@mail.gmail.com>
On Wed, 19 May 2010 10:49:59 +0900
Jassi Brar <jassisinghbrar@gmail.com> wrote:
> On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah <rsarmah@amcc.com> wrote:
> > This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX.
>
> The controller seems to be a thrid party IP (from Synopsys) in your
> SoC and there are many chances the IP will appear in some other
> SOCs too. This implementation doesn't seem to take care of that
> scenario.
I'd question if that is worth it seriously. At the point there are
multiple users of the device you know what it will look like. Until then
you neither know if the work is needed nor what will require abstracting.
Lazy evaluation is good for code too ;)
Alan
next prev parent reply other threads:[~2010-05-19 9:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 17:57 Rupjyoti Sarmah
2010-05-14 17:44 ` Sergei Shtylyov
2010-05-15 23:40 ` Benjamin Herrenschmidt
2010-05-17 10:06 ` Stefan Roese
2010-05-17 10:36 ` Benjamin Herrenschmidt
2010-05-14 21:56 ` Jeff Garzik
2010-05-19 1:49 ` Jassi Brar
2010-05-19 9:53 ` Alan Cox [this message]
2010-05-19 11:19 ` Jassi Brar
2010-06-04 12:26 [PATCH]460EX on-chip SATA driver<kernel 2.6.33><resubmission> Rupjyoti Sarmah
2010-06-06 18:52 ` Josh Boyer
2010-06-06 21:09 ` Wolfgang Denk
2010-06-18 4:34 ` Jassi Brar
2010-06-29 1:33 ` Marek Vasut
2010-06-29 12:20 ` Rupjyoti Sarmah
2010-06-29 12:44 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519105305.54804b57@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jassisinghbrar@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rsarmah@amcc.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®