From: Randy Dunlap <randy.dunlap@oracle.com>
To: akpm@linux-foundation.org, InKi Dae <inki.dae@samsung.com>,
Richard Purdie <rpurdie@rpsys.net>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH -mmotm] backlight: fix s6e63m0 kconfig
Date: Thu, 20 May 2010 14:08:29 -0700 [thread overview]
Message-ID: <20100520140829.11233713.randy.dunlap@oracle.com> (raw)
In-Reply-To: <201005192341.o4JNf5Hv012931@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix kconfig file dependency and help text.
Move the driver's Kconfig symbol inside the LCD_CLASS_DEVICE block.
When CONFIG_BACKLIGHT_CLASS_DEVICE is not enabled:
ERROR: "backlight_device_register" [drivers/video/backlight/s6e63m0.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: InKi Dae <inki.dae@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
---
Looks like several backlight/LCD drivers have this kind of relationship.
drivers/video/backlight/Kconfig | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
--- mmotm-2010-0519-1612.orig/drivers/video/backlight/Kconfig
+++ mmotm-2010-0519-1612/drivers/video/backlight/Kconfig
@@ -101,14 +101,16 @@ config LCD_HP700
If you have an HP Jornada 700 series handheld (710/720/728)
say Y to enable LCD control driver.
-endif # LCD_CLASS_DEVICE
-
config LCD_S6E63M0
tristate "S6E63M0 AMOLED LCD Driver"
- depends on LCD_CLASS_DEVICE && SPI
+ depends on SPI && BACKLIGHT_CLASS_DEVICE
default n
help
- If you have an S6E63M0 LCD Panel say Y to enable LCD control driver
+ If you have an S6E63M0 LCD Panel, say Y to enable its
+ LCD control driver.
+
+endif # LCD_CLASS_DEVICE
+
#
# Backlight
#
next prev parent reply other threads:[~2010-05-20 21:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 23:13 mmotm 2010-05-19-16-12 uploaded akpm
2010-05-20 15:21 ` mmotm 2010-05-19 - Kconfig dependency list from hell Valdis.Kletnieks
2010-05-20 15:47 ` mmotm 2010-05-19 BUG weirdness Valdis.Kletnieks
2010-05-20 12:55 ` Andrew Morton
2010-05-20 16:45 ` Dmitry Torokhov
2010-05-20 17:52 ` Valdis.Kletnieks
2010-05-20 18:17 ` [2.6.34 PATCH] kernel: fix exit message for dead process Valdis.Kletnieks
2010-05-20 18:36 ` Andrew Morton
2010-05-20 21:08 ` [PATCH -mmotm] media: ak881x needs slab.h Randy Dunlap
2010-06-01 6:04 ` Ingo Molnar
2010-05-20 21:08 ` Randy Dunlap [this message]
2010-05-20 21:08 ` [PATCH -mmotm] backlight: fix s6e63m0 device attr function return types Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520140829.11233713.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=inki.dae@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome