From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757359Ab0EUCSe (ORCPT ); Thu, 20 May 2010 22:18:34 -0400 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:46677 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755428Ab0EUCSd (ORCPT ); Thu, 20 May 2010 22:18:33 -0400 X-SecurityPolicyCheck-FJ: OK by FujitsuOutboundMailChecker v1.3.1 From: KOSAKI Motohiro To: Hugh Dickins Subject: Re: [PATCH] tmpfs: Insert tmpfs cache pages to inactive list at first Cc: kosaki.motohiro@jp.fujitsu.com, Shaohua Li , Wu Fengguang , Johannes Weiner , Rik van Riel , Minchan Kim , LKML , linux-mm , Andrew Morton In-Reply-To: References: <20100521103935.1E56.A69D9226@jp.fujitsu.com> Message-Id: <20100521111658.1E64.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Date: Fri, 21 May 2010 11:18:24 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Fri, 21 May 2010, KOSAKI Motohiro wrote: > > > > > Acked-by: Hugh Dickins > > > > > > Thanks - though I don't quite agree with your description: I can't > > > see why the lru_cache_add_active_anon() was ever justified - that > > > "active" came in along with the separate anon and file LRU lists. > > > > If you have any worry, can you please share it? I'll test such workload > > and fix the issue if necessary. You are expert than me in this area. > > ?? I've acked the patch: my worry is only with the detail of your > comments on the history - in my view it was always wrong to put on > the active LRU there, and I'm glad that you have now fixed it. Oops, I misparsed your text. very sorry. I thought you said opposite ;) Thanks. > If you really want to test some workload on 2.6.28 to see if it too > works better with your fix, I won't stop you - but I'd much prefer > you to be applying your mind to 2.6.35 and 2.6.36! > > Hugh > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/