From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Thomas Gleixner <tglx@linutronix.de>, John Stultz <johnstul@us.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [Regression] Negative time on Acer Ferrari One with current -git
Date: Sat, 22 May 2010 23:20:01 +0200 [thread overview]
Message-ID: <201005222320.01506.rjw@sisk.pl> (raw)
In-Reply-To: <201005222255.27301.rjw@sisk.pl>
On Saturday 22 May 2010, Rafael J. Wysocki wrote:
> On Saturday 22 May 2010, Thomas Gleixner wrote:
> > On Sat, 22 May 2010, Thomas Gleixner wrote:
> >
> > > On Sat, 22 May 2010, Rafael J. Wysocki wrote:
> > > > On Saturday 22 May 2010, Thomas Gleixner wrote:
> > > >
> > > > > Also which clocksource is used ?
> > > >
> > > > hpet
> > >
> > > Hmm, there is only one hpet related commit sin .34: 30a564be9d
> > > and I can hardly see how this should be related.
> >
> > Does the problem persist if you disable HPET on the kernel command line ?
>
> I didn't try that, but I bisected it in the meantime which lead to:
>
> commit 64ce4c2f5252f25798117fa80a027993163d6d84
> Author: John Stultz <johnstul@us.ibm.com>
> Date: Thu Mar 11 14:04:47 2010 -0800
>
> time: Clean up warp_clock()
>
> warp_clock() currently accesses timekeeping internal state directly, which
> is unnecessary. Convert it to use the proper timekeeping interfaces.
>
> Signed-off-by: John Stultz <johnstul@us.ibm.com>
> Cc: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> So I don't think it's an hpet issue. :-)
>
> I'm now going to revert that commit and see what happens.
After reverting commit 64ce4c2f above things work again.
To be precise, I reverted both commit 64ce4c2f and commit 6a867a3 (time:
Remove xtime_cache), but since the symptoms continued to apprear after
reverting the latter alone, it's quite clear that commit 64ce4c2f breaks things
on this box.
Thanks,
Rafael
next prev parent reply other threads:[~2010-05-22 21:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 21:43 Rafael J. Wysocki
2010-05-21 22:19 ` Linus Torvalds
2010-05-21 22:39 ` john stultz
2010-05-22 17:54 ` Rafael J. Wysocki
2010-05-22 14:05 ` Thomas Gleixner
2010-05-22 14:18 ` Thomas Gleixner
2010-05-22 17:34 ` Rafael J. Wysocki
2010-05-22 17:52 ` Borislav Petkov
2010-05-22 18:00 ` Rafael J. Wysocki
2010-05-22 18:25 ` Thomas Gleixner
2010-05-22 18:32 ` Thomas Gleixner
2010-05-22 20:55 ` Rafael J. Wysocki
2010-05-22 21:20 ` Rafael J. Wysocki [this message]
2010-05-23 6:40 ` Thomas Gleixner
2010-05-23 13:21 ` Rafael J. Wysocki
2010-05-23 21:20 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005222320.01506.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@linux-foundation.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome