mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alasdair G Kergon <agk@redhat.com>
To: Will Drewry <wad@chromium.org>
Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org, snitzer@redhat.com
Subject: Re: [dm-devel] [PATCH v3 3/3] dm: lookup devices by path with name_to_dev_t
Date: Mon, 24 May 2010 12:57:37 +0100	[thread overview]
Message-ID: <20100524115737.GY3991@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <1274294304-30606-3-git-send-email-wad@chromium.org>

On Wed, May 19, 2010 at 01:38:24PM -0500, Will Drewry wrote:
> +	char base_path[32];  /* size from name_to_dev_t */
  
> +	/* stage the shorter path for name_to_dev_t. */
> +	strncpy(base_path, path, sizeof(base_path));

I'm dropping that, and just passing path directly, so the strlen test
will be used.  (There's a "name += 5" in there so 32 would ignore
any longer standard names anyway.)

Alasdair


  parent reply	other threads:[~2010-05-24 11:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19 18:38 [PATCH v3 1/3] dm: allow a dm-fs-style device to be shared via dm-ioctl Will Drewry
2010-05-19 18:38 ` [PATCH v3 2/3] init: boot to device-mapper targets without an initr* Will Drewry
2010-05-19 18:38 ` [PATCH v3 3/3] dm: lookup devices by path with name_to_dev_t Will Drewry
2010-05-24 11:38   ` [dm-devel] " Alasdair G Kergon
2010-05-24 11:57   ` Alasdair G Kergon [this message]
2010-05-24 14:44     ` Will Drewry
2010-05-24 15:07       ` Alasdair G Kergon
2010-05-24 16:35         ` Will Drewry
2010-05-24 23:35           ` Mike Snitzer
2010-05-24 23:55             ` Mike Snitzer
2010-05-25 15:58               ` Will Drewry
2010-05-24 16:33 ` [PATCH 1/2] dm: ensure dm_table_complete() completes a table for use Will Drewry
2010-05-24 16:33 ` [PATCH 2/2] dm: export a table+mapped device to the ioctl interface Will Drewry
2010-06-08  3:25 ` [PATCH v4 1/3] dm: ensure dm_table_complete() completes a table for use Will Drewry
2010-06-08  3:25 ` [PATCH v4 2/3] dm: export a table+mapped device to the ioctl interface Will Drewry
2010-06-08  3:25 ` [PATCH v4 3/3] init: add support to directly boot to a mapped device Will Drewry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100524115737.GY3991@agk-dp.fab.redhat.com \
    --to=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®