From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755998Ab0EXS5W (ORCPT ); Mon, 24 May 2010 14:57:22 -0400 Received: from ksp.mff.cuni.cz ([195.113.26.206]:33110 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754654Ab0EXS5V (ORCPT ); Mon, 24 May 2010 14:57:21 -0400 Date: Mon, 24 May 2010 20:57:11 +0200 From: Pavel Machek To: Arve Hj?nnev?g Cc: James Kosin , linux-kernel@vger.kernel.org Subject: Re: [linux-pm] [PATCH 1/8] PM: Add suspend block api. Message-ID: <20100524185710.GB1292@ucw.cz> References: <4BE37DDD.8000402@cox.net> <4BE38290.6040404@cnu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> One if the benefit we get from using suspend is that an unprivileged > >> app that does not have access to suspend blockers cannot prevent > >> suspend. You lose this advantage if you trigger suspend only from the > >> idle task. > >> > >> > > If the process (privileged or unprivileged) doesn't want to suspend, why > > not just provide an interface to allow suspend to be turned off at the > > user level.  This could block the suspend cycle in itself, and you > > shouldn't need fine grained off/on cycles.  If an application really > > needs the system not to suspend then they (the user) should know the > > consequences and power requirements for such a task. > > > > I didn't say it had to be only from the idle task; but, that is the most > > logical place.  If the other threads are not idle then they really > > require work and will most likely already have a bock on the suspend anyway. > > > > I think you missed my point. Unprivileged processes should not be > allowed to prevent suspend. Currently, unpriviledged processes are allowed to eat power, for example while(1). We should keep that behaviour at least by default. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html