From: Glauber Costa <glommer@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, zamsden@redhat.com
Subject: Re: [PATCH] Add Documentation/kvm/msr.txt
Date: Thu, 27 May 2010 13:02:48 -0300 [thread overview]
Message-ID: <20100527160248.GF3445@mothafucka.localdomain> (raw)
In-Reply-To: <4BFE2A2F.50209@redhat.com>
On Thu, May 27, 2010 at 11:15:43AM +0300, Avi Kivity wrote:
> On 05/26/2010 09:04 PM, Glauber Costa wrote:
> >This patch adds a file that documents the usage of KVM-specific
> >MSRs.
> >
>
> Looks good. A few comments:
>
> >+
> >+Custom MSR list
> >+--------
> >+
> >+The current supported Custom MSR list is:
> >+
> >+MSR_KVM_WALL_CLOCK: 0x11
> >+
> >+ data: physical address of a memory area.
>
> Which must be in guest RAM (i.e., don't point it somewhere random
> and expect the hypervisor to allocate it for you).
>
> Must be aligned to 4 bytes (we don't enforce it though).
I don't see the reason for it.
If this is a requirement, our own implementation
is failing to meet it.
next prev parent reply other threads:[~2010-05-27 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 18:04 Glauber Costa
2010-05-26 18:35 ` Randy Dunlap
2010-05-26 18:59 ` Glauber Costa
2010-05-27 8:15 ` Avi Kivity
2010-05-27 16:02 ` Glauber Costa [this message]
2010-05-27 20:13 ` Zachary Amsden
2010-05-27 20:36 ` Glauber Costa
2010-05-27 21:02 ` Zachary Amsden
2010-05-28 0:10 ` Glauber Costa
2010-05-28 4:10 ` Zachary Amsden
2010-05-30 9:14 ` Avi Kivity
2010-05-31 13:49 ` Glauber Costa
2010-05-31 14:03 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527160248.GF3445@mothafucka.localdomain \
--to=glommer@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome