From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932699Ab0E0V0u (ORCPT ); Thu, 27 May 2010 17:26:50 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:48444 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932556Ab0E0V0s (ORCPT ); Thu, 27 May 2010 17:26:48 -0400 Date: Thu, 27 May 2010 22:34:18 +0100 From: Alan Cox To: Alan Stern Cc: Peter Zijlstra , Felipe Balbi , Thomas Gleixner , Arve =?ISO-8859-14?B?SGr4bm5lduVn?= , LKML , Florian Mickler , Linux OMAP Mailing List , Linux PM Subject: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 8) Message-ID: <20100527223418.281a687f@lxorguk.ukuu.org.uk> In-Reply-To: References: <1274980420.27810.5557.camel@twins> X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 May 2010 13:29:18 -0400 (EDT) Alan Stern wrote: > On Thu, 27 May 2010, Peter Zijlstra wrote: > > > On Thu, 2010-05-27 at 13:04 -0400, Alan Stern wrote: > > > > > > Does this mean you believe "echo mem >/sys/power/state" is bad and > > > should be removed? Or "echo disk >/sys/power/state"? They pay no > > > attention to latencies or other requirements. > > > > Those are a whole different beast, those are basically a quick-off > > button like thing. Forced suspend is conceptually a very different beast > > from power-saving a running system. > > They may be different conceptually. Nevertheless, Android uses forced > suspend as a form of power saving. Until better mechanisms are in > place, it makes sense. For them, not for Linux. Several vendors have exciting kernel drivers that do things like binary patch other modules. Until better mechanisms are in place it does *NOT* make sense to merge such stuff. I don't care what they do in their own tree (consenting adults in their own home and all that) but what they do in the public tree is another matter. Alan