From: Arjan van de Ven <arjan@infradead.org>
To: Thomas Renninger <trenn@suse.de>
Cc: davej@redhat.com, linux-kernel@vger.kernel.org,
robert.schoene@tu-dresden.de, cpufreq@vger.kernel.org,
linux-perf-users@vger.kernel.org,
linux-trace-users@vger.kernel.org, x86@kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] x86 cpufreq: Make trace_power_frequency cpufreq driver independent
Date: Fri, 28 May 2010 18:42:13 -0700 [thread overview]
Message-ID: <20100528184213.76c09515@infradead.org> (raw)
In-Reply-To: <1274791199-12335-1-git-send-email-trenn@suse.de>
On Tue, 25 May 2010 14:39:59 +0200
Thomas Renninger <trenn@suse.de> wrote:
> and fix the broken case if a core's frequency depends on others.
>
> trace_power_frequency was only implemented in a rather ungeneric way
> in acpi-cpufreq driver's target() function only.
> -> Move the call to trace_power_frequency to
> cpufreq.c:cpufreq_notify_transition() where CPUFREQ_POSTCHANGE
> notifier is triggered.
> This will support power frequency tracing by all cpufreq drivers
>
> trace_power_frequency did not trace frequency changes correctly when
> the userspace governor was used or when CPU cores' frequency depend
> on each other.
> -> Moving this into the CPUFREQ_POSTCHANGE notifier and pass the cpu
> which gets switched automatically fixes this.
while I'm no great fan of having a second field in the perf structure
for the cpu... I can see that Thomas has a use case where this solves
his issue...
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
prev parent reply other threads:[~2010-05-29 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 12:39 Thomas Renninger
2010-05-25 12:53 ` Thomas Renninger
2010-05-28 16:39 ` Thomas Renninger
2010-05-29 1:42 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528184213.76c09515@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-trace-users@vger.kernel.org \
--cc=robert.schoene@tu-dresden.de \
--cc=trenn@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome