From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>, Oleg Nesterov <oleg@redhat.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Nick Piggin <npiggin@suse.de>
Cc: kosaki.motohiro@jp.fujitsu.com
Subject: [PATCH 2/5] oom: remove warning for in mm-less task __oom_kill_process()
Date: Tue, 1 Jun 2010 14:48:05 +0900 (JST) [thread overview]
Message-ID: <20100601144705.243D.A69D9226@jp.fujitsu.com> (raw)
In-Reply-To: <20100601144238.243A.A69D9226@jp.fujitsu.com>
If the race of mm detach in task exiting vs oom is happen,
find_lock_task_mm() can be return NULL.
So, the warning is pointless. remove it.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
mm/oom_kill.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index bac4515..70e1a85 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -402,12 +402,8 @@ static int __oom_kill_process(struct task_struct *p, struct mem_cgroup *mem,
return 1;
p = find_lock_task_mm(p);
- if (!p) {
- WARN_ON(1);
- printk(KERN_WARNING "tried to kill an mm-less task %d (%s)!\n",
- task_pid_nr(p), p->comm);
+ if (!p)
return 1;
- }
if (verbose)
printk(KERN_ERR "Killed process %d (%s) "
--
1.6.5.2
next prev parent reply other threads:[~2010-06-01 5:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 5:46 [PATCH 1/5] oom: make oom_unkillable() helper function KOSAKI Motohiro
2010-06-01 5:48 ` KOSAKI Motohiro [this message]
2010-06-01 7:20 ` [PATCH 2/5] oom: remove warning for in mm-less task __oom_kill_process() David Rientjes
2010-06-01 5:49 ` [PATCH 3/5] oom: Fix child process iteration properly KOSAKI Motohiro
2010-06-01 19:27 ` Oleg Nesterov
2010-06-02 13:53 ` KOSAKI Motohiro
2010-06-01 5:50 ` [PATCH 4/5] oom-kill: give the dying task a higher priority (v4) KOSAKI Motohiro
2010-06-01 5:51 ` [PATCH 5/5] oom: dump_tasks() use find_lock_task_mm() too KOSAKI Motohiro
2010-06-02 13:54 ` KOSAKI Motohiro
2010-06-02 15:03 ` Minchan Kim
2010-06-03 0:06 ` KOSAKI Motohiro
2010-06-03 0:32 ` Minchan Kim
2010-06-03 0:41 ` KOSAKI Motohiro
2010-06-03 0:46 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601144705.243D.A69D9226@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=oleg@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome