From: David Fries <david@fries.net>
To: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Cc: Kailang Yang <kailang@realtek.com>, Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] regression 2.6.35-rc1+ hda realtek missing beep 10ec0883
Date: Tue, 1 Jun 2010 23:31:31 -0500 [thread overview]
Message-ID: <20100602043129.GE22327@spacedout.fries.net> (raw)
From: David Fries <david@fries.net>
The PC-Spekaer Beep control worked in 2.6.34, but not 2.6.35-rc1, this
is the patch that modified that behavior.
"ALSA: hda - Add parse customize define function for Realtek codecs"
regression in commit da00c24493bf6ae3772dfe7343dca033ebc75955.
Debug output (after this patch),
HDA Intel 0000:00:14.2: PCI INT A -> GSI 16 (level, low) -> IRQ 16
SKU: Nid=0x0 sku_cfg=0x0000140d
SKU: port_connectivity=0x0
SKU: enable_pcbeep=0x0
SKU: check_sum=0x00000000
SKU: customization=0x00000000
SKU: external_amp=0x1
SKU: platform_type=0x1
SKU: swap=0x0
SKU: override=0x1
hda_codec: ALC883: BIOS auto-probing.
autoconfig: line_outs=1 (0x14/0x0/0x0/0x0/0x0)
speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
hp_outs=0 (0x0/0x0/0x0/0x0/0x0)
mono: mono_out=0x0
dig-out=0x1e/0x0
inputs: mic=0x18, fmic=0x0, line=0x1a, fline=0x0, cd=0x1c, aux=0x0
realtek: Enabling init ASM_ID=0x140d CODEC_ID=10ec0883
input: HDA Digital PCBeep as /devices/pci0000:00/0000:00:14.2/input/input16
Signed-off-by: David Fries <david@fries.net>
Cc: Kailang Yang <kailang@realtek.com>
Cc: Takashi Iwai <tiwai@suse.de>
---
My patch restores both the Beep volume and mute. I'll let someone
else determine if this is the correct solution or not.
sound/pci/hda/patch_realtek.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 17d4548..c31c8b9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10611,7 +10611,7 @@ static int patch_alc882(struct hda_codec *codec)
set_capture_mixer(codec);
- if (spec->cdefine.enable_pcbeep)
+ if (spec->cdefine.enable_pcbeep || codec->vendor_id == 0x10ec0883)
set_beep_amp(spec, 0x0b, 0x05, HDA_INPUT);
if (board_config == ALC882_AUTO)
--
1.7.1
reply other threads:[~2010-06-02 4:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602043129.GE22327@spacedout.fries.net \
--to=david@fries.net \
--cc=alsa-devel@alsa-project.org \
--cc=kailang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®