From: Marc Zyngier <maz@misterjones.org>
To: Esben Haabendal <esbenhaabendal@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Esben Haabendal <eha@doredevelopment.dk>,
linux-kernel@vger.kernel.org, mingo@elte.hu,
joachim.eastwood@jotron.com
Subject: Re: [RFC][PATCH] irq: support IRQ_NESTED_THREAD with non-threaded interrupt handlers
Date: Sat, 5 Jun 2010 18:18:16 +0100 [thread overview]
Message-ID: <20100605181816.7aae71c7@hina.wild-wind.fr.eu.org> (raw)
In-Reply-To: <AANLkTilUGOVPBtdl2KB2nrbra8uBO8q4AX0v57hCtr_9@mail.gmail.com>
On Sat, 5 Jun 2010 18:53:53 +0200
Esben Haabendal <esbenhaabendal@gmail.com> wrote:
> On Sat, Jun 5, 2010 at 4:10 PM, Marc Zyngier <maz@misterjones.org> wrote:
> > On Sat, 5 Jun 2010 15:56:01 +0200
> > Esben Haabendal <esbenhaabendal@gmail.com> wrote:
> >
> >> I have a board with an I2C PCA9535 chip with two PHY interrupt lines
> >> hooked up to. The pca953x driver calls set_irq_nested_thread on all
> >> irq's on initialization. The PHY driver then calls request_irq, and has
> >> no idea that it should actually be using a threaded handler.
> >>
> >> With this patch, the PHY driver is able to work in this scenario
> >> without changes (and so should any other driver using request_irq).
> >
> > You may want to give request_any_context_irq() a try (available since
> > the latest merge window). It still requires your driver to be changed,
> > but it should then work in both threaded and non-threaded cases.
>
> The problem is not in "my" driver, but in the phy driver framework in this
> particular case.
To me, any driver/subsystem/whatever qualifies as "yours" if you're taking
care of it ;-).
> What is the plan here, should all drivers change from
> request_any_context_irq() at some point in time?
All? Probably not. Only the few where the need arises, and after carefully
checking that you're not introducing a horrible race condition somewhere
(threaded handlers are running with interrupts enabled...).
M.
--
Enforcement officers may use a hand-held detection device to measure both
the direction and the strength of a TV signal. This makes it easy for us
to locate TV receiving equipment in even the hardest-to-reach places.
next prev parent reply other threads:[~2010-06-05 17:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 21:19 Esben Haabendal
2010-06-04 21:46 ` Thomas Gleixner
2010-06-05 13:56 ` Esben Haabendal
2010-06-05 14:10 ` Marc Zyngier
2010-06-05 15:33 ` Thomas Gleixner
2010-06-05 17:01 ` Esben Haabendal
2010-06-05 18:52 ` Thomas Gleixner
2010-06-05 19:48 ` Esben Haabendal
2010-06-05 20:14 ` Thomas Gleixner
2010-06-06 19:50 ` Esben Haabendal
2010-06-06 22:08 ` Thomas Gleixner
2010-06-07 12:34 ` Esben Haabendal
2010-06-07 15:06 ` Thomas Gleixner
2010-06-07 21:28 ` Esben Haabendal
2010-06-07 23:18 ` Thomas Gleixner
2010-06-08 14:15 ` Esben Haabendal
2010-06-08 6:58 ` Thomas Gleixner
2010-06-08 7:23 ` Esben Haabendal
2010-06-05 16:53 ` Esben Haabendal
2010-06-05 17:18 ` Marc Zyngier [this message]
2010-06-05 19:38 ` Esben Haabendal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100605181816.7aae71c7@hina.wild-wind.fr.eu.org \
--to=maz@misterjones.org \
--cc=eha@doredevelopment.dk \
--cc=esbenhaabendal@gmail.com \
--cc=joachim.eastwood@jotron.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®