From: Sam Ravnborg <sam@ravnborg.org>
To: Nicolas Palix <npalix@diku.dk>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Roland Dreier <rdreier@cisco.com>, Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Michal Marek <mmarek@suse.cz>, Julia Lawall <julia@diku.dk>,
Gilles Muller <Gilles.Muller@lip6.fr>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
cocci@diku.dk, Wolfram Sang <w.sang@pengutronix.de>,
Kernel Janitors <kernel-janitors@vger.kernel.org>,
Am?rico Wang <xiyou.wangcong@gmail.com>,
Andy Isaacson <adi@hexapodia.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
walter harms <wharms@bfs.de>, Joerg Roedel <joro@8bytes.org>,
Jan Engelhardt <jengelh@medozas.de>
Subject: Re: [PATCH 1/7] Add a target to use the Coccinelle checker
Date: Sun, 6 Jun 2010 20:16:07 +0200 [thread overview]
Message-ID: <20100606181607.GA15535@merkur.ravnborg.org> (raw)
In-Reply-To: <1275837307-4283-2-git-send-email-npalix@diku.dk>
On Sun, Jun 06, 2010 at 05:15:01PM +0200, Nicolas Palix wrote:
> A 'coccicheck' target is added. It can be called with four different
> modes. Each one generates a different kind of output, i.e. context,
> patch, org, report, according to the corresponding mode to be
> activated.
>
> The new target calls the 'coccicheck' front-end in the 'scripts'
> directory with the MODE argument. Every SmPL file in the
> subdirectories of 'scripts/coccinelle' is then given to the front-end
> and applied to the entire source tree.
>
> The four modes behave as follows:
>
> 'report' generates a list in the following format:
> file:line:column-column: message
>
> 'patch' proposes a fix, when possible.
>
> 'context' highlights lines of interest and their context in a
> diff-like style. Lines of interest are indicated with '-'.
>
> 'org' generates a report in the Org mode format of Emacs.
>
> Signed-off-by: Nicolas Palix <npalix@diku.dk>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Hi Nicolas.
This is almost what I had in mind - thanks.
Most importantly it no longer add all the stuff
to the top-level Makefile but defer this to a script.
If/when we decide to move all the checkers to scripts/*
we can do the last adjustments.
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam
next prev parent reply other threads:[~2010-06-06 18:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-06 15:15 [PATCH 0/7] Add some checks to be used with Coccinelle Nicolas Palix
2010-06-06 15:15 ` [PATCH 1/7] Add a target to use the Coccinelle checker Nicolas Palix
2010-06-06 18:16 ` Sam Ravnborg [this message]
2010-06-07 12:35 ` Nicolas Palix
2010-06-30 18:58 ` Kulikov Vasiliy
2010-06-30 21:52 ` Nicolas Palix
2010-07-02 13:52 ` Kulikov Vasiliy
2010-07-02 14:30 ` Nicolas Palix
2010-07-02 20:11 ` Michal Marek
2010-06-06 15:15 ` [PATCH 2/7] Add Documentation/coccinelle.txt Nicolas Palix
2010-06-06 15:15 ` [PATCH 3/7] Add scripts/coccinelle/alloc/drop_kmalloc_cast.cocci Nicolas Palix
2010-06-06 15:15 ` [PATCH 4/7] Add scripts/coccinelle/alloc/kzalloc-simple.cocci Nicolas Palix
2010-06-06 15:15 ` [PATCH 5/7] Add scripts/coccinelle/resource_size.cocci Nicolas Palix
2010-06-06 15:15 ` [PATCH 6/7] Add scripts/coccinelle/err_cast.cocci Nicolas Palix
2010-06-06 15:15 ` [PATCH 7/7] Add scripts/coccinelle/deref_null.cocci Nicolas Palix
2010-06-10 11:52 ` [PATCH 0/7] Add some checks to be used with Coccinelle Joerg Roedel
2010-06-11 22:02 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100606181607.GA15535@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=Gilles.Muller@lip6.fr \
--cc=adi@hexapodia.org \
--cc=akpm@linux-foundation.org \
--cc=cocci@diku.dk \
--cc=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=joe@perches.com \
--cc=joro@8bytes.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=npalix@diku.dk \
--cc=penberg@cs.helsinki.fi \
--cc=rdreier@cisco.com \
--cc=rdunlap@xenotime.net \
--cc=torvalds@linux-foundation.org \
--cc=w.sang@pengutronix.de \
--cc=wharms@bfs.de \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®