mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Frank Pan <frankpzh@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	Yu Zhao <yu.zhao@intel.com>, Chris Wright <chrisw@sous-sol.org>,
	Mitch Williams <mitch.a.williams@intel.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	"David S. Miller" <davem@davemloft.net>,
	Matt Carlson <mcarlson@broadcom.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Add a helper function in PCI IOV to get VF device
Date: Tue, 8 Jun 2010 14:35:14 -0700	[thread overview]
Message-ID: <20100608143514.740f8095@virtuousgeek.org> (raw)
In-Reply-To: <AANLkTimTm57fvumRXo9pegOY2M78mduBsClwYlmAOzpo@mail.gmail.com>

On Tue, 1 Jun 2010 13:05:25 +0800
Frank Pan <frankpzh@gmail.com> wrote:

> Greetings,
> 
> The motivation is make VF device visible to PF driver. PF driver
> may need this to access VF's PCI configuration.
> Another use case is in sysfs symbolic linking. Some of VF's sysfs
> entries are created by PF driver. For example, /sys/class/net/ethx/vfx
> in Intel 82576 NIC driver. Makeing a symbolic link from VF's pci device
> to this path also must be done in PF's driver.
> 
> Currently, there is no hint about VF's bus/devfn in PF's pci_dev.
> The offset and stride entries(which are used to calculate bus/devfn
> of VF devices) in VF's PCI configuration is also invisible in PF's
> driver. So IMO this helper function is needed.
> 
> Any reply is appreciated, THX.
> 
> (ps: gmail will do line wrap/tab replace, use attachment instead to patch)

Per the discussion in this thread it sounds like this really has
nothing to do with sysfs and more to do with being a convenient API for
drivers.

Is that correct?  If so, and assuming there's not some other way of
getting this info from a driver, I'm ok with it, but it should be
submitted as part of a patchset including driver code that uses it.

-- 
Jesse Barnes, Intel Open Source Technology Center

  parent reply	other threads:[~2010-06-08 21:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01  5:05 Frank Pan
2010-06-01 18:39 ` Greg KH
2010-06-01 18:57   ` Williams, Mitch A
2010-06-02  6:12     ` Frank Pan
2010-06-02 18:59       ` Williams, Mitch A
2010-06-03  2:57         ` Frank Pan
2010-06-03  3:11           ` Frank Pan
2010-06-03 17:10             ` Williams, Mitch A
2010-06-04  2:28               ` Frank Pan
2010-06-03 17:56           ` Chris Wright
2010-06-04  2:43             ` Frank Pan
2010-06-08 22:12               ` Chris Wright
2010-06-02  6:02   ` Frank Pan
2010-06-08 21:35 ` Jesse Barnes [this message]
2010-06-11  7:42   ` Frank Pan
2010-06-18 17:17     ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100608143514.740f8095@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=akpm@linux-foundation.org \
    --cc=chrisw@sous-sol.org \
    --cc=davem@davemloft.net \
    --cc=frankpzh@gmail.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mcarlson@broadcom.com \
    --cc=mitch.a.williams@intel.com \
    --cc=rjw@sisk.pl \
    --cc=yu.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®