mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wim Van Sebroeck <wim@iguana.be>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Hans-Christian Egtvedt <hcegtvedt@atmel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: setting miscdevice.parent after misc_register()
Date: Tue, 8 Jun 2010 21:34:18 +0200	[thread overview]
Message-ID: <20100608193418.GF3788@infomag.iguana.be> (raw)
In-Reply-To: <AANLkTilDZdke5V6TYtDheK9rCaxTDHqtoPR7I_tEvFR2@mail.gmail.com>

Hi Akinobu,

> In drivers/watchdog/at32ap700x_wdt.c, and drivers/watchdog/sch311x_wdt.c
> miscdevice.parent is set after misc_register().
> 
> drivers/watchdog/at32ap700x_wdt.c:
> 
> 	ret = misc_register(&wdt->miscdev);
> 	...
> 	wdt->miscdev.parent = &pdev->dev;
> 
> But it does nothing. (the miscdevice will not be a child of that parent
> device in sysfs)
> 
> So should it be set before misc_register() or just keep it as-is?

It should be fixed by setting it before the misc_register call.
I'll do the necessary.

Thanks,
Wim.


      parent reply	other threads:[~2010-06-08 19:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-08  3:11 Akinobu Mita
2010-06-08  6:46 ` Hans-Christian Egtvedt
2010-06-08 19:34 ` Wim Van Sebroeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100608193418.GF3788@infomag.iguana.be \
    --to=wim@iguana.be \
    --cc=akinobu.mita@gmail.com \
    --cc=hcegtvedt@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®