From: TAMUKI Shoichi <tamuki@linet.gr.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Anton Blanchard <anton@samba.org>,
Andi Kleen <andi@firstfloor.org>, Andy Green <andy@warmcat.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
TAMUKI Shoichi <tamuki@linet.gr.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] panic: keep blinking in spite of long spin timer mode
Date: Fri, 11 Jun 2010 07:31:13 +0900 [thread overview]
Message-ID: <201006102231.AA00429@tamuki.linet.gr.jp> (raw)
In-Reply-To: <20100609151552.d1a8ca8d.akpm@linux-foundation.org>
Hello,
On Wed, 9 Jun 2010 15:15:52 -0700 Andrew Morton wrote:
> Morse code? Kidding?
I'm sorry, I'm confusing you.
> Sorry, no. Nobody who uses this feature will know what what
> "words per minute" means. It's nutty!
That is just a strained interpretation where the measure of the
blinking speed comes from. The description of "words per minute"
has already disappeared in the latest patch.
> Please remind me why we're making this configurable at all. Can't we
> just hardwire the thing to 1Hz or something? Add an
> im_using_a_hypervisor boot option or something, if necessary?
For now, gta02_panic_blink(), one of panic_blink() users, expects a
10Hz call rate. IOW, it blinks at 5Hz (i.e. panicblink=36). I think
that the desirable blinking speed is different according to devices.
Regards,
TAMUKI Shoichi
next prev parent reply other threads:[~2010-06-10 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-03 22:01 TAMUKI Shoichi
2010-06-03 22:30 ` Andrew Morton
2010-06-06 13:19 ` TAMUKI Shoichi
2010-06-09 22:15 ` Andrew Morton
2010-06-10 2:30 ` Anton Blanchard
2010-06-10 22:31 ` TAMUKI Shoichi
2010-06-10 22:31 ` TAMUKI Shoichi [this message]
2010-06-14 21:14 ` Andrew Morton
2010-06-15 22:25 ` TAMUKI Shoichi
2010-06-06 13:33 ` [PATCH v2.1] " TAMUKI Shoichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006102231.AA00429@tamuki.linet.gr.jp \
--to=tamuki@linet.gr.jp \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=andy@warmcat.com \
--cc=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®