mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Divyesh Shah <dpshah@google.com>
To: jaxboe@fusionio.com
Cc: peterz@infradead.org, mingo@elte.hu, piotr@hosowicz.com,
	linux-kernel@vger.kernel.org, vgoyal@redhat.com
Subject: [PATCH 1/2] Remove preempt_enable/disable calls around sched_clock()
Date: Fri, 11 Jun 2010 19:34:52 -0700	[thread overview]
Message-ID: <20100612023409.14850.76309.stgit@austin.mtv.corp.google.com> (raw)

calls in the block layer. This was a temporary fix added.

Signed-off-by: Divyesh Shah <dpshah@google.com>
---
 include/linux/blkdev.h |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 09a8402..ebe788e 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1218,16 +1218,12 @@ int kblockd_schedule_work(struct request_queue *q, struct work_struct *work);
  */
 static inline void set_start_time_ns(struct request *req)
 {
-	preempt_disable();
 	req->start_time_ns = sched_clock();
-	preempt_enable();
 }
 
 static inline void set_io_start_time_ns(struct request *req)
 {
-	preempt_disable();
 	req->io_start_time_ns = sched_clock();
-	preempt_enable();
 }
 
 static inline uint64_t rq_start_time_ns(struct request *req)


             reply	other threads:[~2010-06-12  2:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-12  2:34 Divyesh Shah [this message]
2010-06-12  2:35 ` [PATCH 2/2] Use ktime_get() instead of sched_clock() for blkio cgroup stats Divyesh Shah
2010-06-12  7:18   ` Ingo Molnar
2010-06-12 15:51     ` Divyesh Shah
2010-06-12  7:19 ` [PATCH 1/2] Remove preempt_enable/disable calls around sched_clock() Ingo Molnar
2010-06-12 15:52   ` Divyesh Shah
2010-06-13 10:01     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100612023409.14850.76309.stgit@austin.mtv.corp.google.com \
    --to=dpshah@google.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=piotr@hosowicz.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®