From: Willy Tarreau <w@1wt.eu>
To: "Henri Häkkinen" <henuxd@gmail.com>
Cc: gregkh@suse.de, peterhuewe@gmx.de, julia@diku.dk,
sudhakar.raj@ti.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:panel: Fixed coding conventions.
Date: Sat, 12 Jun 2010 06:49:51 +0200 [thread overview]
Message-ID: <20100612044951.GB15336@1wt.eu> (raw)
In-Reply-To: <1276291656-2898-1-git-send-email-henuxd@gmail.com>
On Sat, Jun 12, 2010 at 12:27:36AM +0300, Henri Häkkinen wrote:
> Fixed coding convention issues as reported by checkpatch.pl tool
> on the file `panel.c'. Moved LCD special code handling from the
> function `lcd_write' into function `handle_lcd_special_code'. Also
> moved the handling of INPUT_ST_HIGH and INPUT_ST_FALLING states from
> the function `panel_process_input' into functions `input_state_high'
> and `input_state_falling'.
>
> Signed-off-by: Henri Häkkinen <henuxd@gmail.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Thank you Henri, this version is *a lot* better than previous one,
and the result is overall cleaner than the original.
Regards,
Willy
next prev parent reply other threads:[~2010-06-12 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 21:27 Henri Häkkinen
2010-06-12 4:49 ` Willy Tarreau [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-06-11 12:21 Henri Häkkinen
2010-06-11 12:44 ` Willy Tarreau
2010-06-11 12:20 Henri Häkkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100612044951.GB15336@1wt.eu \
--to=w@1wt.eu \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=henuxd@gmail.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=sudhakar.raj@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome