Re: Noticeable slow-down in 2.6.35-rc3

[Gene Heskett <gene.heskett@gmail.com>]

On Monday 14 June 2010, walt wrote:
>On 06/13/2010 03:13 PM, Gene Heskett wrote:
>> Unfortunately, this patch will not apply to my src tree for 2.6.35-rc3,
>> even after I fixed the unwanted line wrap in the first active line.
>>
>> I get:
>>
>> [root@coyote linux-2.6.35-rc3]# patch -p1<../2.6.35-rc3-test.patch
>> patching file net/core/skbuff.c
>> Hunk #1 FAILED at 532.
>> 1 out of 1 hunk FAILED -- saving rejects to file net/core/skbuff.c.rej
>>
>> Did my grabbing it with swiftfox damage it even further?
>> ------------------------------------------------------------------
>> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
>> index 9f07e74..bcf2fa3 100644
>> --- a/net/core/skbuff.c
>> +++ b/net/core/skbuff.c
>> @@ -532,6 +532,7 @@ static void __copy_skb_header(struct sk_buff *new,
>> const struct sk_buff *old) new-&gt;ip_summed		= old-&gt;ip_summed;
>
>I don't know what caused the corruption, but it's a systematic error.
>Throughout the patch, the dereference symbol -> has been changed to
>-& so it's not surprising that the patch won't apply.  I've never seen
>that particular problem before.
>
Neither have I, but that looks to be fixable, so I will give it a shot later 
today.  Thank you very much.

>I don't think the line numbers (e.g.532) are responsible.

Neither did I.

-- 
Cheers, Gene
"There are four boxes to be used in defense of liberty:
 soap, ballot, jury, and ammo. Please use in that order."
-Ed Howdershelt (Author)
This fortune was brought to you by the people at Hewlett-Packard.