Re: [PATCH] max730x: make pullups configurable via platformdata

[Wolfram Sang <w.sang@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On Tue, Jun 15, 2010 at 10:01:01AM +0200, Marc Kleine-Budde wrote:
> The gpios on the max730x chips have support for internal pullups
> while in input mode.
> 
> This patch adds support for configuring these pullups via platform data.
> A new member ("input_pullup_active") to the platform data struct is
> introduced. A set bit in this variable activates the pullups while the
> respective port is in input mode. This is a compatible enhancement since
> unset bits lead to disables pullups which was the default in the
> original driver.
> 
> _Note_: the 4 lowest bits in "input_pullup_active" are unused because
> the first 4 ports of the controller are not used, too.
> 
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

Marc an I already discussed the previous versions, so:

Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]