From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932977Ab0FQPOo (ORCPT ); Thu, 17 Jun 2010 11:14:44 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:37738 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932768Ab0FQPOm (ORCPT ); Thu, 17 Jun 2010 11:14:42 -0400 Date: Thu, 17 Jun 2010 16:17:54 +0100 From: Alan Cox To: Jean Delvare Cc: Jonathan Cameron , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hmc6352: Add driver for the HMC6352 compass Message-ID: <20100617161754.39bd116e@lxorguk.ukuu.org.uk> In-Reply-To: <20100617165250.5986fbf7@hyperion.delvare> References: <20100616121534.26294.12540.stgit@localhost.localdomain> <20100616151056.181234b0@hyperion.delvare> <20100617125056.6d648ee7@lxorguk.ukuu.org.uk> <4C1A12C6.6070704@cam.ac.uk> <20100617141440.030f1de9@lxorguk.ukuu.org.uk> <20100617165250.5986fbf7@hyperion.delvare> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > These functions are supposed to return count on success. Instead, you > are returning 1. Ah yes - I only tested with 1 byte sized I/O. Fixed - do you want this to go via the I2C tree ?