From: Jean Delvare <khali@linux-fr.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hmc6352: Add driver for the HMC6352 compass
Date: Thu, 17 Jun 2010 17:56:50 +0200 [thread overview]
Message-ID: <20100617175650.482e098f@hyperion.delvare> (raw)
In-Reply-To: <20100617161754.39bd116e@lxorguk.ukuu.org.uk>
On Thu, 17 Jun 2010 16:17:54 +0100, Alan Cox wrote:
> > These functions are supposed to return count on success. Instead, you
> > are returning 1.
>
> Ah yes - I only tested with 1 byte sized I/O.
Good.
> Fixed - do you want this to go via the I2C tree ?
No.
--
Jean Delvare
next prev parent reply other threads:[~2010-06-17 15:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 12:16 Alan Cox
2010-06-16 12:43 ` Oliver Neukum
2010-06-17 11:20 ` Alan Cox
2010-06-17 12:26 ` Oliver Neukum
2010-06-17 12:46 ` Alan Cox
2010-06-16 13:10 ` Jean Delvare
2010-06-17 11:50 ` Alan Cox
2010-06-17 12:19 ` Jonathan Cameron
2010-06-17 13:14 ` Alan Cox
2010-06-17 14:52 ` Jean Delvare
2010-06-17 15:17 ` Alan Cox
2010-06-17 15:56 ` Jean Delvare [this message]
2010-06-16 14:46 ` Jonathan Cameron
2010-06-17 11:34 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100617175650.482e098f@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jic23@cam.ac.uk \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome