mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Howard Chu <hyc@symas.com>
Cc: linux-kernel@vger.kernel.org, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] tty: Add EXTPROC support for LINEMODE
Date: Thu, 17 Jun 2010 21:49:15 +0100	[thread overview]
Message-ID: <20100617214915.3478e501@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <4C1A7F72.6020907@symas.com>

> >> For Alpha this value should match OSF if possible.
> 
> OSF didn't define this flag, nor did it assign that particular bit to any 
> purpose. Is that good enough?

Fine

> > Are you suggesting that this is completely unfixable/unworkable? Would it be
> > sufficient to use kernel_termios_to_user_termios() ?

I don't see a way to fix it sanely

> >
> Actually using kernel_termios_to_user_termios_1(). In all supported 
> architectures this structure is basically aligned with but smaller than the 
> userland struct termios.

The relationship isn't quite so simple and it may change in the future,
so this seems to be a very bad idea. Besides which syscalls are *cheap*
so simply notifying someone to reread the terminal data they care about
should be fine. In that sense it seems SVR4 got it right.

Alan

  reply	other threads:[~2010-06-17 20:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15 18:56 hyc
2010-06-15 19:29 ` Alan Cox
2010-06-15 19:54   ` Howard Chu
2010-06-15 20:23     ` Howard Chu
2010-06-16 15:13       ` Derek Fawcus
2010-06-17 20:02     ` Howard Chu
2010-06-17 20:49       ` Alan Cox [this message]
2010-06-17 21:23         ` Howard Chu
2010-06-17 23:43           ` Howard Chu
2010-06-16  1:15   ` Chris Adams
2010-06-18 19:45 hyc
2010-06-18 22:20 ` Howard Chu
2010-06-22 15:59 ` Howard Chu
2010-06-22 16:03   ` Greg KH
2010-06-22 17:28   ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100617214915.3478e501@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=hyc@symas.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®