From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org, Greg KH <gregkh@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
John Kacur <jkacur@redhat.com>, Al Viro <viro@zeniv.linux.org.uk>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] tty: avoid recursive BTM in pty_close
Date: Fri, 18 Jun 2010 17:21:21 +0100 [thread overview]
Message-ID: <20100618172121.528f2e09@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <201006181458.07687.arnd@arndb.de>
> I'd like to get Alan's opinion on whether he considers the change in
> pty.c safe.
I considered it a while ago when trying to work out removing the BKL from
this path. After much head banging and an overwhelming desire to go and
get drunk instead I concluded it wasn't possible to tell by analysis.
So I ack this patch - it's the only way to find out 8)
Alan
next prev parent reply other threads:[~2010-06-18 16:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 20:59 [PATCH v3 00/10] BKL conversion in tty layer Arnd Bergmann
2010-05-15 20:59 ` [PATCH 01/10] tty: replace BKL with a new tty_lock Arnd Bergmann
2010-05-15 20:59 ` [PATCH 02/10] tty: never hold BTM while getting tty_mutex Arnd Bergmann
2010-05-15 20:59 ` [PATCH 03/10] tty: fix console_sem lock order Arnd Bergmann
2010-05-15 20:59 ` [PATCH 04/10] cdc-acm: remove dead code Arnd Bergmann
2010-05-15 20:59 ` [PATCH 05/10] tty: introduce wait_event_interruptible_tty Arnd Bergmann
2010-05-15 20:59 ` [PATCH 06/10] tty: annotate tty_write_lock Arnd Bergmann
2010-05-15 20:59 ` [PATCH 07/10] tty: reorder ldisc locking Arnd Bergmann
2010-05-15 20:59 ` [PATCH 08/10] tty: untangle locking of wait_until_sent Arnd Bergmann
2010-05-16 3:12 ` Daniel K.
2010-05-15 20:59 ` [PATCH 09/10] tty: remove tty_lock_nested Arnd Bergmann
2010-05-15 20:59 ` [PATCH 10/10] tty: implement BTM as mutex instead of BKL Arnd Bergmann
2010-05-16 3:33 ` Daniel K.
2010-05-16 12:58 ` Arnd Bergmann
2010-05-17 13:41 ` [PATCH v3 00/10] BKL conversion in tty layer Alan Cox
2010-05-17 15:30 ` Greg KH
2010-05-17 18:30 ` Arnd Bergmann
2010-05-18 4:27 ` Greg KH
2010-05-18 21:52 ` Arnd Bergmann
2010-05-19 1:50 ` Greg KH
2010-05-22 13:54 ` Arnd Bergmann
2010-05-17 18:49 ` Arnd Bergmann
2010-06-17 19:13 ` Tony Luck
2010-06-17 19:40 ` Arnd Bergmann
2010-06-17 20:15 ` Tony Luck
2010-06-17 21:48 ` Arnd Bergmann
2010-06-17 22:09 ` Frederic Weisbecker
2010-06-18 12:58 ` [PATCH] tty: avoid recursive BTM in pty_close Arnd Bergmann
2010-06-18 16:21 ` Alan Cox [this message]
2010-06-18 16:52 ` Tony Luck
2010-06-18 18:35 ` Arnd Bergmann
2010-06-18 20:25 ` Tony Luck
2010-06-19 12:32 ` Arnd Bergmann
2010-06-19 20:29 ` [PATCH] serial: revert "Use block_til_ready helper" Arnd Bergmann
2010-06-19 21:57 ` Alan Cox
2010-06-20 20:54 ` Arnd Bergmann
2010-06-21 14:13 ` Alan Cox
2010-06-21 20:57 ` Arnd Bergmann
2010-06-21 20:58 ` Arnd Bergmann
2010-06-21 17:11 ` Tony Luck
2010-06-22 23:01 ` Greg KH
2010-06-28 17:17 ` [PATCH] tty: avoid recursive BTM in pty_close Tony Luck
2010-06-28 19:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100618172121.528f2e09@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=fweisbec@gmail.com \
--cc=gregkh@suse.de \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome