mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, dzickus@redhat.com
Subject: Re: [PATCH] Add TAINT_HARDWARE_UNSUPPORTED flag
Date: Sat, 19 Jun 2010 10:30:56 +0100	[thread overview]
Message-ID: <20100619103056.194fb221@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20100617134654.22523.39845.sendpatchset@prarit.bos.redhat.com>

> Typically, one would push a config patch to enable and disable the feature and
> patch the distribution.  However, in some cases this is not feasible in order

If you can push a patch to set the flag you can push a patch to panic or
reject that combination.

Devil's advocate time: 

Also the fact some distributions chose a binary compatible interface for
their internal modules was their choice. It is one that has been
repeatedly rejected by upstream and at kernel summit.

So given we fundamnetally reject your approach why should we carry your
flag ?

> In some cases the distribution may want to allow booting of these features but
> explicitly notify a user that they are not "officially" supported.  It is also

We have printk. You can add a module of your own which indicates
'support' status too.

> possible that the hardware is fixed via a firmware update at a later date,
> making it supported again.

IMHO it's not properly named in the first place. You are talking about
combinations of hardware/firmware and you actually mean 'configuration
not supported' ?

> This patch introduces the TAINT_HARDWARE_UNSUPPORTED flag for distributions
> to use.

and why KERN_CRIT when the other printk's don't use that level ?

A suggestion: instead of all this push a single patch with a comment and
maybe defines indicating that taint flag bits 28-31 are 'reserved' for
experimental and out of tree applications.

That way anyone who has a requirement like yours can deal with it and
nobody has to worry about bit collisions, naming and the like. Nor if you
suddenely need an extra bit in 3 years time are you going to come unstuck
on your KABI. That will help other people doing experiments with taint or
with differing needs to the Red Hat one.

Alan

  parent reply	other threads:[~2010-06-19  9:27 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-17 13:54 Prarit Bhargava
2010-06-17 16:13 ` Randy Dunlap
2010-06-17 19:54   ` Prarit Bhargava
2010-06-17 20:28     ` Randy Dunlap
2010-06-21 19:21     ` Andrew Morton
2010-06-21 19:45       ` Don Zickus
2010-06-21 20:00         ` Andrew Morton
2010-06-21 20:46           ` Don Zickus
2010-06-22 15:34           ` [PATCH v3] " Don Zickus
2010-06-22 15:48             ` Alan Cox
2010-06-22 16:38               ` Matthew Garrett
2010-06-22 16:57                 ` Alan Cox
2010-06-22 17:04                   ` Matthew Garrett
2010-06-23  3:06                     ` Paul Mundt
2010-06-23  3:30                       ` Matthew Garrett
2010-06-23 20:00                         ` Don Zickus
2010-06-22 18:58               ` [PATCH v4] " Don Zickus
2010-07-06 20:33                 ` Don Zickus
2010-07-06 22:18                   ` Alan Cox
2010-06-19  8:40 ` [PATCH] " Andi Kleen
2010-06-19  9:30 ` Alan Cox [this message]
2010-06-21 13:26   ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100619103056.194fb221@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=dzickus@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=prarit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®