mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Feuerer <peter@piie.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Feuerer <peter@piie.net>,
	linux-kernel@vger.kernel.org,
	Borislav Petkov <petkovbb@googlemail.com>,
	lenb@kernel.org, Andreas Mohr <andi@lisas.de>
Subject: [PATCH 3/4] Driver didn't verify the pointers in which it got product information
Date: Sat, 19 Jun 2010 13:44:46 +0200	[thread overview]
Message-ID: <20100619134446.7b5e76d3.peter@piie.net> (raw)
In-Reply-To: <20100619134343.46564310.peter@piie.net>

[PATCH 3/4] Driver didn't verify the pointers in which it got product information
 back from DMI; on QEMU one of the pointers came back null,
 which made the driver crash and subsequently caused a kernel panic.

From: Rahul Chaturvedi <rkc@chromium.org>
Signed-off-by: Rahul Chaturvedi <rkc@chromium.org>
Signed-off-by: Peter Feuerer <peter@piie.net>
Cc: Borislav Petkov <petkovbb@gmail.com>
Cc: Andreas Mohr <andi@lisas.de>
Cc: Len Brown <lenb@kernel.org>

---
 drivers/platform/x86/acerhdf.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index 9226838..6abd3f1 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -524,6 +524,10 @@ static int acerhdf_check_hardware(void)
 	version = dmi_get_system_info(DMI_BIOS_VERSION);
 	product = dmi_get_system_info(DMI_PRODUCT_NAME);
 
+	if (!vendor || !version || !product) {
+		pr_err("error getting hardware information\n");
+		return -EINVAL;
+	}
 
 	pr_info("Acer Aspire One Fan driver, v.%s\n", DRV_VER);
 
-- 
1.7.1


  reply	other threads:[~2010-06-19 11:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-19 11:42 [PATCH 1/4] Acerhdf: Added new BIOS versions for Acer 1410 and 1810xx and Packard Bell Peter Feuerer
2010-06-19 11:43 ` [PATCH 2/4] Removed "chk_off" as it was only needed for T31 netbooks Peter Feuerer
2010-06-19 11:44   ` Peter Feuerer [this message]
2010-06-19 11:45     ` [PATCH 4/4] Added AO531 and many BIOS versions for 1410, 1810xx and packard bell netbooks Peter Feuerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100619134446.7b5e76d3.peter@piie.net \
    --to=peter@piie.net \
    --cc=akpm@linux-foundation.org \
    --cc=andi@lisas.de \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome