Re: [PATCH] Support for the pressure sensor BMP085 from Bosch Sensortec.

[Andrew Morton <akpm@linux-foundation.org>]

On Sun, 20 Jun 2010 22:50:58 +0200
Christoph Mair <christoph.mair@gmail.com> wrote:

> This driver adds support for the BMP085 digital pressure sensor
> from Bosch Sensortec.

If there's a datasheet available, it would be nice to provide a
reference to that in the driver.

> It exposes a sysfs api to userspace where
> pressure and temperature measurement results can be read from the
> pressure0_input and temp0_input file. The chip is able to calculate
> the average of up to eight samples to increase the accuracy.
> This feature can be controlled by writing to the oversampling file.
> 

You didn't adequately (IMO) describe the most important thing: the
userspace interface.

Please do send a full description of the proposed API so we can review
that.  What are the contents of these files?  What are the units of
those contents, etc?

Are there any similar drivers in the tree (I don't think so) and if so
does this new driver offer the same interface?

Bear in mind that if new drivers for similar devices _do_ come along
then we'd prefer that those drivers implement the same interface as
this one.  So is this driver's interface well-designed from that point
of view?

Also, we're supposed to docuemnt these things formally in
Documentation/ABI/.

>
> ...
>
> + * The chip will use 2^oversampling samples for interlan averaging.

I assumed that was supposed to read "internal".