From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758448Ab0FUUkE (ORCPT ); Mon, 21 Jun 2010 16:40:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758417Ab0FUUj7 (ORCPT ); Mon, 21 Jun 2010 16:39:59 -0400 Date: Mon, 21 Jun 2010 16:33:37 -0400 From: Rik van Riel To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, aarcange@redhat.com, linux-mm@kvack.org Subject: [PATCH -mm 1/6] mmap: remove unnecessary lock from __vma_link Message-ID: <20100621163337.5781bbc2@annuminas.surriel.com> In-Reply-To: <20100621163146.4e4e30cb@annuminas.surriel.com> References: <20100621163146.4e4e30cb@annuminas.surriel.com> Organization: Red Hat, Inc. Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrea Arcangeli Subject: remove unnecessary lock from __vma_link There's no anon-vma related mangling happening inside __vma_link anymore so no need of anon_vma locking there. Signed-off-by: Andrea Arcangeli Signed-off-by: Rik van Riel --- diff --git a/mm/mmap.c b/mm/mmap.c --- a/mm/mmap.c +++ b/mm/mmap.c @@ -469,12 +469,10 @@ static void vma_link(struct mm_struct *m spin_lock(&mapping->i_mmap_lock); vma->vm_truncate_count = mapping->truncate_count; } - vma_lock_anon_vma(vma); __vma_link(mm, vma, prev, rb_link, rb_parent); __vma_link_file(vma); - vma_unlock_anon_vma(vma); if (mapping) spin_unlock(&mapping->i_mmap_lock);