Re: [PATCH 1/2] firewire: core: no need to track irq flags in bm_work

[Philippe De Muyter <phdm@macqel.be>]

On Mon, Jun 21, 2010 at 11:23:52PM +0200, Stefan Richter wrote:
> This is a workqueue job and always entered with IRQs enabled.

did you mean 'disabled' ?

Philippe

> 
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
>  drivers/firewire/core-card.c |   15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> Index: b/drivers/firewire/core-card.c
> ===================================================================
> --- a/drivers/firewire/core-card.c
> +++ b/drivers/firewire/core-card.c
> @@ -239,7 +239,6 @@ static void fw_card_bm_work(struct work_
>  	struct fw_card *card = container_of(work, struct fw_card, work.work);
>  	struct fw_device *root_device, *irm_device;
>  	struct fw_node *root_node;
> -	unsigned long flags;
>  	int root_id, new_root_id, irm_id, local_id;
>  	int gap_count, generation, grace, rcode;
>  	bool do_reset = false;
> @@ -247,10 +246,10 @@ static void fw_card_bm_work(struct work_
>  	bool root_device_is_cmc;
>  	bool irm_is_1394_1995_only;
>  
> -	spin_lock_irqsave(&card->lock, flags);
> +	spin_lock_irq(&card->lock);