mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dale Farnsworth <dale@farnsworth.org>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Andrew Morton <akpm@linux-foundation.org>,
	rtc-linux <rtc-linux@googlegroups.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RTC/max6900: use rtc_valid_tm to check returning tm for max6900
Date: Tue, 22 Jun 2010 05:47:09 -0700	[thread overview]
Message-ID: <20100622124709.GA6170@farnsworth.org> (raw)
In-Reply-To: <4C207DAF.7010200@gmail.com>

On Tue, Jun 22, 2010 at 05:09:03PM +0800, Wan ZongShun wrote:
> Use rtc_valid_tm to check returning tm for max6900,
> it can avoid returning wrong tm value.
> ---
>  drivers/rtc/rtc-max6900.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c
> index a4f6665..486142c 100644
> --- a/drivers/rtc/rtc-max6900.c
> +++ b/drivers/rtc/rtc-max6900.c
> @@ -159,7 +159,7 @@ static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm)
>  		      bcd2bin(regs[MAX6900_REG_CENTURY]) * 100 - 1900;
>  	tm->tm_wday = bcd2bin(regs[MAX6900_REG_DW]);
> 
> -	return 0;
> +	return rtc_valid_tm(tm);
>  }
> 
>  static int max6900_i2c_clear_write_protect(struct i2c_client *client)

Ack.

Thanks,
-Dale

      parent reply	other threads:[~2010-06-22 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-22  9:09 Wan ZongShun
2010-06-22  9:41 ` Wan ZongShun
2010-06-22 12:47 ` Dale Farnsworth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100622124709.GA6170@farnsworth.org \
    --to=dale@farnsworth.org \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcuos.com@gmail.com \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome