From: TAMUKI Shoichi <tamuki@linet.gr.jp>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Anton Blanchard <anton@samba.org>,
Andi Kleen <andi@firstfloor.org>, Andy Green <andy@warmcat.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Dmitry Torokhov <dtor@mail.ru>,
TAMUKI Shoichi <tamuki@linet.gr.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] panic: keep blinking in spite of long spin timer mode
Date: Thu, 24 Jun 2010 07:35:34 +0900 [thread overview]
Message-ID: <201006232235.AA00445@tamuki.linet.gr.jp> (raw)
In-Reply-To: <20100622131654.05032c22.akpm@linux-foundation.org>
Hello,
On Tue, 22 Jun 2010 13:16:54 -0700 Andrew Morton wrote:
> > To keep panic_timeout accuracy when running under a hypervisor, the
> > current implementation only spins on long time (1 second) calls to
> > mdelay. That brings a good effect, but the problem is the keyboard
> > LEDs don't blink at all on that situation.
> >
> > This patch changes to call to panic_blink_enter() between every mdelay
> > and keeps blinking in spite of long spin timer mode.
> >
> > The time to call to mdelay is now 100ms. Even this change will keep
> > panic_timeout accuracy enough when running under a hypervisor.
>
> Thaks for sticking with it - I think the code's a lot better now. Are
> you happy with it?
Oh, yes. That's very thoughtful of you.
Regards,
TAMUKI Shoichi
prev parent reply other threads:[~2010-06-23 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-20 22:52 TAMUKI Shoichi
2010-06-22 20:16 ` Andrew Morton
2010-06-22 20:33 ` Dmitry Torokhov
2010-06-23 22:35 ` TAMUKI Shoichi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006232235.AA00445@tamuki.linet.gr.jp \
--to=tamuki@linet.gr.jp \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=andy@warmcat.com \
--cc=anton@samba.org \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®