mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
	David Woodhouse <David.Woodhouse@intel.com>,
	linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
	kernel-janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] staging/spectra: remove non existing blk_fs_request wrapper
Date: Fri, 25 Jun 2010 08:43:12 -0700	[thread overview]
Message-ID: <20100625084312.8199b158.randy.dunlap@oracle.com> (raw)
In-Reply-To: <1277440848.18981.9.camel@lenovo>

On Fri, 25 Jun 2010 00:40:48 -0400 Javier Martinez Canillas wrote:

> The spectra driver doesn't compile with today linux-next
> 
> The problem is that it tries to use a blk_fs_request macro. Searching for this macro I saw that it used to exist in linux/blkdev.h as
> 
> #define blk_fs_request(rq) ((rq)->cmd_type == REQ_TYPE_FS)
> 
> This patch solves the issue eliminating the unnecessary (and now inexistent) wrapper
> 
> Best regards,
> 
> >From 755f948d65ff67d5dc8dde8c2edd212cbe61bd5f Mon Sep 17 00:00:00 2001
> From: Javier Martinez Canillas <martinez.javier@gmail.com>
> Date: Fri, 25 Jun 2010 00:26:20 -0400
> Subject: [PATCH] staging/spectra: remove non existing blk_fs_request wrapper
> 
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.

> ---
>  drivers/staging/spectra/ffsport.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/spectra/ffsport.c b/drivers/staging/spectra/ffsport.c
> index 3c3565d..d0c5c97 100644
> --- a/drivers/staging/spectra/ffsport.c
> +++ b/drivers/staging/spectra/ffsport.c
> @@ -304,7 +304,7 @@ static int do_transfer(struct spectra_nand_dev *tr, struct request *req)
>  			return 0;
>  	}
>  
> -	if (!blk_fs_request(req))
> +	if (req->cmd_type != REQ_TYPE_FS)
>  		return -EIO;
>  
>  	if (blk_rq_pos(req) + blk_rq_cur_sectors(req) > get_capacity(tr->gd)) {
> -- 
> 1.7.0.4
> 
> 
> 
> 
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

      reply	other threads:[~2010-06-25 15:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-25  4:40 Javier Martinez Canillas
2010-06-25 15:43 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100625084312.8199b158.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=David.Woodhouse@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martinez.javier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®